Skip to content

ci: try rector ^2.2.5 to allow global phpunit#1637

Merged
brendt merged 8 commits intotempestphp:mainfrom
samsonasik:try-rector-dev-main
Nov 6, 2025
Merged

ci: try rector ^2.2.5 to allow global phpunit#1637
brendt merged 8 commits intotempestphp:mainfrom
samsonasik:try-rector-dev-main

Conversation

@samsonasik
Copy link
Contributor

@samsonasik samsonasik commented Oct 11, 2025

@TomasVotruba @brendt here I try latest rector dev-main to allow global PHPUnit usage.

@samsonasik samsonasik changed the title Try Rector dev-main to allow global PHPUnit ci:Try Rector dev-main to allow global PHPUnit Oct 11, 2025
@samsonasik samsonasik changed the title ci:Try Rector dev-main to allow global PHPUnit ci: Try Rector dev-main to allow global PHPUnit Oct 11, 2025
@samsonasik samsonasik changed the title ci: Try Rector dev-main to allow global PHPUnit ci: try rector dev-main to allow global phpununit Oct 11, 2025
@samsonasik samsonasik mentioned this pull request Oct 11, 2025
Closed
@samsonasik samsonasik changed the title ci: try rector dev-main to allow global phpununit ci: try rector dev-main to allow global phpunit Oct 11, 2025
@samsonasik
Copy link
Contributor Author

samsonasik commented Oct 11, 2025

@TomasVotruba @brendt Finally 🎉 All green 🎉 🎉 🎉

This can wait for new Rector release :)

@samsonasik samsonasik closed this Oct 11, 2025
@samsonasik samsonasik reopened this Oct 11, 2025
@samsonasik
Copy link
Contributor Author

samsonasik commented Oct 11, 2025

Close-ReOpen to restart build of latest rector/rector:dev-main 👍

@samsonasik
Copy link
Contributor Author

samsonasik commented Oct 11, 2025

@TomasVotruba @brendt it green on latest dev-main 🎉 🎉 🎉

@samsonasik
Copy link
Contributor Author

samsonasik commented Oct 11, 2025

Also updated to use rector/rector:dev-main on upgrade/composer.json 15f83d0

@samsonasik
Copy link
Contributor Author

samsonasik commented Oct 11, 2025 •
edited
Loading

New Github UI on firefox is hard to look latest changes on "Files Changed" tab, I changed both root composer.json and upgrade composer.json

3adaaa3 and 15f83d0

@samsonasik
Copy link
Contributor Author

samsonasik commented Oct 11, 2025

@TomasVotruba @brendt it green on latest dev-main 🎉 🎉 🎉

@samsonasik
Copy link
Contributor Author

samsonasik commented Oct 11, 2025

Let's bump to Rector ^2.2.3 78fa3e2

@samsonasik samsonasik changed the title ci: try rector dev-main to allow global phpunit ci: try rector ^2.2.3 to allow global phpunit Oct 11, 2025
@samsonasik
Copy link
Contributor Author

samsonasik commented Oct 11, 2025

@TomasVotruba @brendt it green on latest 2.2.3 🎉 🎉 🎉

@samsonasik
Copy link
Contributor Author

samsonasik commented Oct 14, 2025

@TomasVotruba @brendt let's try latest dev-main to test latest patch of autoload on dev-main 5887ec1

@samsonasik
Copy link
Contributor Author

samsonasik commented Oct 14, 2025

@TomasVotruba @brendt it seems working OK with latest dev-main 👍 , style check notice seems unrelated

@brendt
Copy link
Member

brendt commented Oct 17, 2025

I understand this PR was for testing, which version should I now use though? ^2.2.3 ?

@samsonasik
Copy link
Contributor Author

samsonasik commented Oct 17, 2025

^2.2.3 is fine, or just wait for next release as include latest patch for PHPUnit 12+ version check on bootstrap.

@brendt
Copy link
Member

brendt commented Oct 17, 2025

I'll wait then :)

@samsonasik samsonasik changed the title ci: try rector ^2.2.3 to allow global phpunit ci: try rector ^2.2.5 to allow global phpunit Oct 24, 2025
@samsonasik
Copy link
Contributor Author

samsonasik commented Oct 24, 2025

@brendt I've updated to ^2.2.5, should be ready for merge now 👍

@brendt brendt merged commit 5b2e307 into tempestphp:main Nov 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik @brendt