Pull Request Test Coverage Report for Build 14122915110

Details

• 558 of 571 (97.72%) changed or added relevant lines in 42 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.4%) to 79.691%

Totals
Change from base Build 14096555604:	0.4%
Covered Lines:	10767
Relevant Lines:	13511

💛 - Coveralls

The two failing tests are because of subcomponent changes

Introduce model definition helper, something like model($objectOrClass)->hasPrimaryKey(), model($objectOrClass)->primaryKeyName() etc.

Not sure I get this (maybe because I lack the context) - so whatever I say next can be completely wrong.

But why don't you, instead, add a #[PrimaryKey()] class attribute (for cases where the table has multi-column primary key) or and a #[Key] property attribute?

Like:

final class Book
{
    #[Key]
    public string $uuid;

    public string $title;

    //...
}

or

#[PrimaryKey(['license_plate', 'state'])]
final class Car
{
    public string $licensePlate;

    public string $state;

    public string $make;

    //...
}

of course, this would also work:

#[PrimaryKey('uuid')]
final class Book
{
    public string $uuid;

    public string $title;

    //...
}

Taking inspiration from dotnet's EF Core: https://learn.microsoft.com/en-us/ef/core/modeling/keys?tabs=data-annotations

You could also add other attributes, like Column('myWeird_columnName'), Required (or, alternatively, Nullable), etc...

Yes, that's what we need to do. However, we first need to do some refactoring to make that work, because id is hardcoded in multiple places atm. It's outside the scope of this PR though: #1086