One issue I have just realised with this is that it won't play nice with tab back and tab forward as when a tab containing a blacklisted URL comes up, the plugin will be disabled.

I think a lot of people use vimari to cycle through tabs and this would break that functionality.

Going to leave this out of the release for the moment while we think of a solution.

Instead of never letting the keys get bound, we could move the URL check into the keypress event itself?

I took a look at how Vimium and VimFX handle blacklists, and it appears they both completely stop reacting to keyboard events on blacklisted sites, even tab switching commands are ignored.

Perhaps we just note that the blacklist will also stop tab switching in the documentation?

Coming from Vimium in Chrome, I understand this behavior and know what I'm getting into when I blacklist a site. I think it's a reasonable expectation and trade-off.

Ok. I will merge this over the weekend. If there is a backlash, we can always remove it.

That's awesome. Thank you sir. It's definitely an opt-in behavior, so I'd imagine it'll go pretty smoothly.

You may want to change the defaults I have in the options. I'll bet a lot of people might confused why their tab switching doesn't work on gmail.

I dont think there should be any 'default' sites. As you say, this can just lead to confusion when it stops working for people on certain pages.

Yeah I agree. Default sites could be a bit of a surprise.

Merged

Added in v1.10