-
Notifications
You must be signed in to change notification settings - Fork 244
Vimari Fork #172
Description
This is mostly targeted at the maintainers of Vimari (which I believe to be @danielcompton and @simeg)
I've been using Vimari for quite some time now but it's been missing some features that I and others would like to see. These include:
- Customisation (Add more key bindings + ability to assign own key bindings #171, Where is the configuration file or how to configure vimari? #166, Open new tab but doesnt make it active. #155, Excluded URLs #153, Add custom keybinding settings #142, Support numeric prefixes #98)
- Better mode isolation (
insertvsnormal) (Support for insert mode #170, Scrolling withjafter pressingdjumps the scroll position to where it was before pressingd#168, Disable Youtube shortcut key for "f" #148, Hitting escape exits full screen #110, Is it possible to exclude certain keys just for certain sites? #102) - Smooth Scrolling (Reload page without cache with
R#157, Scrolling with j and k keys is not smooth. #83) - A help page (Help page with
?#158)
Some of these features have been available in PR's to the project for some time now which I have combined in my own version of Vimari on my own fork.
My fork currently includes:
- update mousetrap library
- configuration support (mostly by the work of @nieldm),
- smooth scrolling
- isolated
normalmode such that issues like Scrolling withjafter pressingdjumps the scroll position to where it was before pressingd#168 don't happen
Before being able to merge these changes back in to the main repo I would like to:
- implement an indicator showing when you are in insert mode.
- introduce some sort of overlay with a help page (although this could be done separately)
- cleanup of legacy code related to how the extension worked before Safari 12. There seems to be some unused code that should probably be removed.
- making sure the extension works properly on macOS Big Sur.
I'm wondering if there is an interest in bringing some of this functionality back to this main repo and send it out to all those using Vimari from the App Store. As I'm already putting in some of my free time on my own fork, I'd be willing to put in some extra time to bring these features back to the main repo. However since the repo has been pretty silent for some time now I'd like to discuss this before putting in the work.
I hope this is the right place to discuss this, please let me know if there is an interest in this and how we could go about it.
