Adding WSL Support + Refactor #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@telesoho Ready for review. I need some help testing it, but I'm fairly confident that everything should just work. |
Owner
|
@knyzorg |
vezaynk
commented
Dec 26, 2021
| let newContent = Paster.parse(content); | ||
| Paster.writeToEditor(newContent); | ||
| } else { | ||
| Paster.pasteImage(); |
Collaborator
Author
There was a problem hiding this comment.
Regression: This codepath was necessary for MacOS.
This was referenced Dec 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runCommand(Useexecinstead of streaming output withspawn)if-elsehell using switchesAccessing clipboard from WSL is done the exact same way as in windows, the only thing to be careful with are that the paths must be converted to window's format.
Tests:
I'm not sure how to setup automated cross-platform tests (especially for WSL). I tested it for WSL, I'll need help testing it for other platforms.
WSL:
Windows 10:
Windows 32:
Darwin (Seems to be missing scripts across the board, no way for it to work):