Skip to content

fix(ci): allow actions token write permission on PR#2650

Merged
chmouel merged 1 commit intotektoncd:mainfrom
zakisk:fix-permission-for-github-token
Apr 8, 2026
Merged

fix(ci): allow actions token write permission on PR#2650
chmouel merged 1 commit intotektoncd:mainfrom
zakisk:fix-permission-for-github-token

Conversation

@zakisk
Copy link
Copy Markdown
Member

@zakisk zakisk commented Apr 8, 2026

this allows actions token i.e. GITHUB_TOKEN write
permission because we need it to delete label in ok-to-test step.

📝 Description of the Change

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

this allows actions token i.e. GITHUB_TOKEN write
permission because we need it to delete label in ok-to-test
step.

Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@chmouel chmouel merged commit 501ba3b into tektoncd:main Apr 8, 2026
5 of 11 checks passed
@zakisk zakisk deleted the fix-permission-for-github-token branch April 8, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants