ci(e2e): use ok-to-test action for permission checks#2628
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the script used to verify pull request author permissions for pull_request_target events. The deleted logic included checks for trusted bots, organization and team membership, repository collaborator status, and the ok-to-test label. I have no feedback to provide as the file was entirely removed.
|
🤔 |
I have moved the actions in a separate repo in pipelines-as-code/ok-to-test |
|
you can see it working here zakisk#17 |
|
but I think e2e tests will always fail as it is using workflow from main |
theakshaypant
left a comment
There was a problem hiding this comment.
Given the potential issues with the script and other options, I personally prefer this over the inline script option.
64daa94 to
bc92dcc
Compare
theakshaypant
left a comment
There was a problem hiding this comment.
LGTM.
I think we need to hold the merge till we get this as an allowed action in tektoncd. cc @vdemeester
Should link the action in the PR description as well
|
/kind ok-to-test |
1 similar comment
|
/kind ok-to-test |
|
/ok-to-test |
bc92dcc to
f18c448
Compare
Replace inline permission check script with the standalone pipelines-as-code/ok-to-test GitHub Action. Signed-off-by: Zaki Shaikh <zashaikh@redhat.com> Assisted-by: Claude Opus 4.6 (via Claude Code)
f18c448 to
6dbf416
Compare
Replace inline permission check script with the standalone pipelines-as-code/ok-to-test GitHub Action.
Assisted-by: Claude Opus 4.6 (via Claude Code)
📝 Description of the Change
🔗 Linked GitHub Issue
Fixes #
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.