fix(ci): remove ok-to-test label immediately after check#2622
fix(ci): remove ok-to-test label immediately after check#2622chmouel merged 1 commit intotektoncd:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the ok-to-test label management within .github/scripts/check-pr-permissions.js by centralizing the label removal logic to the point where the label is processed. Feedback suggests removing leading whitespace from the error message in core.setFailed to improve its appearance in the GitHub Actions UI.
| } catch (err) { | ||
| // 404 is expected when multiple matrix jobs race to remove the same label | ||
| if (err.status !== 404) { | ||
| core.setFailed(` Failed to remove ok-to-test label: ${err.message}`); |
There was a problem hiding this comment.
The error message passed to core.setFailed includes leading spaces. While this aligns with the indentation of core.info logs, core.setFailed messages are often displayed in prominent UI locations (like PR check annotations) where leading whitespace can look awkward and reduce readability. It's better to provide a clean error message without indentation.
| core.setFailed(` Failed to remove ok-to-test label: ${err.message}`); | |
| core.setFailed(`Failed to remove ok-to-test label: ${err.message}`); |
4508b63 to
75028df
Compare
Move label removal from the pre-check phase to right after the ok-to-test label condition passes. This ensures the label is consumed on use, eliminating the need to strip it on subsequent events like synchronize. Signed-off-by: Zaki Shaikh <zashaikh@redhat.com> Assisted-by: Claude Opus 4.6 (via Claude Code)
75028df to
cca242e
Compare
Move label removal from the pre-check phase to right after the ok-to-test label condition passes. This ensures the label is consumed on use, eliminating the need to strip it on subsequent events like synchronize.
Assisted-by: Claude Opus 4.6 (via Claude Code)
📝 Description of the Change
🔗 Linked GitHub Issue
Fixes #
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.