Skip to content

chore: add .gemini configuration file for ignroePaths#2618

Merged
chmouel merged 1 commit intotektoncd:mainfrom
zakisk:add-gemini-config
Mar 31, 2026
Merged

chore: add .gemini configuration file for ignroePaths#2618
chmouel merged 1 commit intotektoncd:mainfrom
zakisk:add-gemini-config

Conversation

@zakisk
Copy link
Copy Markdown
Member

@zakisk zakisk commented Mar 27, 2026 •
edited
Loading

this commit adds .gemini/config.yaml file to specify gemini scope for reviewing file changes. before gemini used to review files under vendor directoy which is not intended as they're third party code and don't want it to be reviewed.

📝 Description of the Change

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

@zakisk zakisk requested a review from chmouel March 27, 2026 10:42
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the .gemini entry from the .gitignore file. The reviewer noted that the associated configuration file mentioned in the PR description is missing and should be included to complete the implementation.

.gitignore
@@ -1,5 +1,4 @@
# Binaries for programs and plugins
.gemini
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The pull request description and commit message state that a .gemini/config.yaml file is being added, but this file is missing from the pull request. This change only un-ignores the .gemini directory. Please add the configuration file to this PR to make it complete.

@chmouel
Copy link
Copy Markdown
Member

chmouel commented Mar 27, 2026

are you sure that works?

@chmouel
Copy link
Copy Markdown
Member

chmouel commented Mar 27, 2026

better luck with this https://developers.google.com/gemini-code-assist/docs/customize-repo-review

@zakisk
Copy link
Copy Markdown
Member Author

zakisk commented Mar 27, 2026

better luck with this https://developers.google.com/gemini-code-assist/docs/customize-repo-review

I read those docs and made this changes 🙂 ignore_paths is specified there

@chmouel
Copy link
Copy Markdown
Member

chmouel commented Mar 27, 2026

ah okay great, then add memory and review to HIGH by default, medium are usually useless

@zakisk
Copy link
Copy Markdown
Member Author

zakisk commented Mar 27, 2026

ah okay great, then add memory and review to HIGH by default, medium are usually useless

you mean comment_severity_threshold? memory_config is enabled by default

@chmouel
Copy link
Copy Markdown
Member

chmouel commented Mar 27, 2026

you mean comment_severity_threshold? memory_config is enabled by default

yeah

@zakisk zakisk force-pushed the add-gemini-config branch from e471976 to e8ed3fe Compare March 30, 2026 11:38
@zakisk
Copy link
Copy Markdown
Member Author

zakisk commented Mar 30, 2026

@chmouel PTAL:

@zakisk
chore: add .gemini configuration file for ignroePaths
8127ed0 
this commit adds .gemini/config.yaml file to specify
gemini scope for reviewing file changes. before gemini
used to review files under vendor directoy which is not
intended as they're third party code and don't want it
to be reviewed.

Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
@zakisk zakisk force-pushed the add-gemini-config branch from e8ed3fe to 8127ed0 Compare March 31, 2026 07:40
@chmouel chmouel merged commit a65895c into tektoncd:main Mar 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chmouel chmouel Awaiting requested review from chmouel

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zakisk @chmouel