feat: integrate testrr for CI test reporting#2606
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces testrr integration into the CI/CD pipelines to provide enhanced visibility and centralized reporting for unit, coverage, and end-to-end tests. By updating existing Tekton and GitHub Actions configurations and adding a dedicated upload script, the project can now automatically push detailed test results to a testrr instance. A key design choice ensures that any issues with the reporting mechanism do not halt the CI process, maintaining pipeline resilience. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request integrates testrr for CI test reporting across Tekton pipelines and GitHub Actions. It introduces a new upload-testrr.sh script to process and upload go test -json output, configures CI workflows to use this script with appropriate environment variables, and updates documentation on the new reporting mechanism. Feedback from the review highlights the unintended removal of the Go race detector flag in Tekton unit tests, a potential issue with tee -a appending to JSON output files in GitHub Actions, and suggests clarifying error messages in the upload-testrr.sh script that incorrectly refer to JUnit files instead of Go test JSON output.
|
/test go-testing |
|
this worked and generated https://testrr.pipelinesascode.com/projects/pipelinesascode |
2ea516e to
b866177
Compare
|
/test doc-deployment |
| pipelinesascode.tekton.dev/on-event: "pull_request" | ||
| pipelinesascode.tekton.dev/on-target-branch: "[*]" | ||
| pipelinesascode.tekton.dev/on-path-change: "[***/*.go]" | ||
| pipelinesascode.tekton.dev/on-path-change: "[***/*.go, .tekton/go.yaml]" |
There was a problem hiding this comment.
may be adding .tekton/generate-coverage-release.yaml as well??
There was a problem hiding this comment.
i think it's fine... we need to fix generate-coverage to øn't try to generte since it doesnt work actually, codecov.io hasbt worked for ages on this repo...
|
/test go-testing |
Added a script to upload test results to testrr and updated Tekton and GitHub Actions pipelines to capture and report unit and E2E test execution data. Configured pipelines to handle upload failures as non-fatal to ensure CI remains resilient. Added documentation on the required setup for test reporting. see an example here: https://testrr.pipelinesascode.com/projects/testrr Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
b866177 to
1672e61
Compare
|
/test go-testing |
|
the failure is related to #2612 let's merge this so we can collect |
Added a script to upload test results to testrr and updated Tekton and GitHub Actions pipelines to capture and report unit and E2E test execution data. Configured pipelines to handle upload failures as non-fatal to ensure CI remains resilient. Added documentation on the required setup for test reporting.
see an example here:
https://testrr.pipelinesascode.com/projects/testrr
📝 Description of the Change
🔗 Linked GitHub Issue
Fixes #
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.