Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request transitions the project's release note generation from a Python script that used the Gemini API to a new, integrated Claude-native skill. This change aims to enhance the reliability and intelligence of release note categorization, streamline the release process, and reduce external dependencies by handling GitHub release updates directly within the Claude environment. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🔍 PR Lint Feedback
|
There was a problem hiding this comment.
Code Review
This pull request replaces the Python-based release note generation script with a new Claude skill. The changes include adding the skill definition and reference documents, updating the release process documentation, and removing the old script and its corresponding CI task. The new skill definition is very detailed, but it misses handling for paginated API responses from GitHub, which could lead to incomplete release notes for large releases. Additionally, there are minor formatting issues in the reference documentation and grammatical errors in the updated process documentation.
| ```bash | ||
| gh api repos/{owner}/{repo}/compare/{previous_tag}...{current_tag} --jq '.commits[].sha' | ||
| ``` |
There was a problem hiding this comment.
The GitHub compare API endpoint is paginated and returns a maximum of 250 commits per request. If a release contains more than 250 commits, the total_commits field in the response will be greater than the number of commits in the commits array. The skill should handle this by paginating through the commits to gather all of them, otherwise release notes for larger releases will be incomplete. The previous Python script (hack/generate-releasenotes.py) had logic for this that could be used as a reference.
| Using claude (or others) skills you can do `/release-notes` to draft the | ||
| release notes it will guide thru the release notes generation and update the | ||
| release notes in the GitHub release page and a Slack announcement. The release | ||
| notes are generated based on the merged PRs since the last release, so it may | ||
| not be perfect, so you should always: |
There was a problem hiding this comment.
This paragraph has some grammatical errors and could be clearer. Consider rephrasing for better readability.
| Using claude (or others) skills you can do `/release-notes` to draft the | |
| release notes it will guide thru the release notes generation and update the | |
| release notes in the GitHub release page and a Slack announcement. The release | |
| notes are generated based on the merged PRs since the last release, so it may | |
| not be perfect, so you should always: | |
| Using Claude skills, you can run the `/release-notes` command to draft the release notes. This will guide you through the generation process, update the release on the GitHub release page, and create a Slack announcement. The release notes are generated based on merged PRs since the last release and may not be perfect, so you should always: |
| \`\`\`shell | ||
| kubectl apply -f https://github.com/{owner}/{repo}/releases/download/{tag}/release.yaml | ||
| \`\`\` |
There was a problem hiding this comment.
The backticks for the shell code blocks are escaped with a backslash (\). This will cause them to render incorrectly in Markdown. Please remove the backslashes. This applies to all shell code blocks in this file.
| \`\`\`shell | |
| kubectl apply -f https://github.com/{owner}/{repo}/releases/download/{tag}/release.yaml | |
| \`\`\` | |
| kubectl apply -f https://github.com/{owner}/{repo}/releases/download/{tag}/release.yaml |
d582e4b to
388694a
Compare
|
/retest |
|
All PipelineRuns for this commit have already succeeded. Use |
|
/retest |
|
All PipelineRuns for this commit have already succeeded. Use |
|
/retest |
|
/ok-to-test |
|
All PipelineRuns for this commit have already succeeded. Use |
Replace the Python-based release note generation script that was run on release with a Claude-native skill. This transition enables automated release note categorization and GitHub release management directly through Claude without relying on external AI API dependencies. The issue is that the gemini api was timing out and was not that smart at categorization, when the skills offer more versatility. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
388694a to
131d636
Compare
| ```markdown | ||
| * **Bold title:** One-sentence description of the change. | ||
| * Link: <PR_OR_COMMIT_URL> | ||
| * Jira: [SRVKP-XXXX](https://issues.redhat.com/browse/SRVKP-XXXX) |
There was a problem hiding this comment.
Do we still want to link Jira to the release notes?
There was a problem hiding this comment.
good quesiton, i think we will keep it, since well it's public most of them and give other contexts
Replace the Python-based release note generation script that was run on
release with a Claude-native skill.
This transition enables automated release note categorization and GitHub
release management directly through Claude without relying on external
AI API dependencies.
The issue is that the gemini api was timing out and was not that smart
at categorization, when the skills offer more versatility.
Signed-off-by: Chmouel Boudjnah chmouel@redhat.com
📝 Description of the Change
👨🏻 Linked Jira
🔗 Linked GitHub Issue
Fixes #
🧪 Testing Strategy
🤖 AI Assistance
If you have used AI assistance, please provide the following details:
Which LLM was used?
Extent of AI Assistance:
Important
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com
**💡You can use the script
./hack/add-llm-coauthor.shto automatically addthese co-author trailers to your commits.
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.