Merged
Conversation
🔍 PR Lint Feedback
|
33 tasks
Member
Author
|
okay so it's not a simple bump, it breaks a lot of things... cc @MartinBasti ie need that as well 171 team, _, err := topts.GiteaCNX.Client().CreateTeam(orgName, forgejo.CreateTeamOption{
172 Permission: forgejo.AccessModeWrite,
173 - Units: []forgejo.RepoUnitType{
174 - forgejo.RepoUnitPulls,
173 + UnitsMap: map[string]string{
174 + string(forgejo.RepoUnitPulls): "write",
175 },
176 Name: teamName,
177 })
``` |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a major version upgrade of the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request bumps the forgejo-sdk dependency from v2 to v3. The changes correctly adapt the codebase to the breaking changes introduced in the new major version of the SDK, specifically in EditPullRequest and CreateAccessToken function calls. A bug fix in error handling within a test helper function has also been included, which prevents a potential panic. The changes look good and address the necessary updates for the dependency bump.
c649304 to
26df5be
Compare
Forgejo sdk v3.0.0 contains commit [1] that fixes request headers. That makes Anubis AI to accept API request. Also bumping mongo diver to v1.17.7, which is new indirect dependency of forgejo-sdk, but v.1.17.6 has CVE-2026-2303 https://codeberg.org/mvdkleijn/forgejo-sdk/ commit/d67f46d514df94f377c3ae73bcc4be41a11c061b Signed-off-by: Martin Basti <mbasti@redhat.com> Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Updated the team creation logic to use the new UnitsMap structure required by the latest Forgejo SDK version. Added explicit error handling for the team creation process to ensure failures are properly returned.
26df5be to
ef92bb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description of the Change
This helps whitelisting pac for anubis protection on fedora
👨🏻 Linked Jira
https://issues.redhat.com/browse/SRVKP-11012
🔗 Linked GitHub Issue
Fixes #
🧪 Testing Strategy
🤖 AI Assistance
If you have used AI assistance, please provide the following details:
Which LLM was used?
Extent of AI Assistance:
Important
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com
**💡You can use the script
./hack/add-llm-coauthor.shto automatically addthese co-author trailers to your commits.
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.