chore: remove all commit prefix checks in pr template#2525
chore: remove all commit prefix checks in pr template#2525zakisk merged 1 commit intotektoncd:mainfrom
Conversation
removed all commit prefix checks in PR template to not make noise in PR. Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request simplifies the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🔍 PR Lint Feedback
|
There was a problem hiding this comment.
Code Review
This pull request removes the 'Type of Change' checklist from the PR template. While the specific comment addresses the obsolescence of a related item in the 'Submitter Checklist', it also emphasizes the importance of retaining guidance for conventional commit types like fix: in the template, as per repository rules. The suggestion is to modify the checklist item rather than simply deleting it, to ensure fix: remains explicitly included.
Note: Security Review has been skipped due to the limited scope of the PR.
I am having trouble creating individual review comments. Click here to see my feedback.
.github/pull_request_template.md (12-28)
The 'Type of Change' section is being removed. However, the pull request template should still include guidance for conventional commit types like fix:, as it is a standard type. The current checklist item - [ ] ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above. refers to the removed section. Instead of removing this line entirely, consider modifying it to refer to a new section that explains conventional commit types, or rephrase it to stand alone, ensuring fix: is still explicitly mentioned as a standard type for commit messages.
References
- The pull request template should include the
fix:conventional commit type as it is a standard type.
removed all commit prefix checks in PR template to not make noise in PR.
📝 Description of the Change
👨🏻 Linked Jira
🔗 Linked GitHub Issue
Fixes #
🚀 Type of Change
fix:)feat:)feat!:,fix!:)docs:)style:)refactor:)perf:)test:)build:)ci:)chore:)revert:)deps:)🧪 Testing Strategy
🤖 AI Assistance
If you have used AI assistance, please provide the following details:
Which LLM was used?
Extent of AI Assistance:
Important
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com
**💡You can use the script
./hack/add-llm-coauthor.shto automatically addthese co-author trailers to your commits.
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.