test: split github_ghe job into 3 parallel chunks by zakisk · Pull Request #2517 · tektoncd/pipelines-as-code

zakisk · 2026-03-02T07:40:20Z

Split the single github_ghe CI matrix entry into github_ghe_1, github_ghe_2, and github_ghe_3 to run GHE E2E tests in parallel, matching the existing gitea chunking pattern. The old github_ghe target is kept as a backward compat alias.

Assisted-by: Claude Opus 4.6 (via Claude Code)

📝 Description of the Change

👨🏻‍ Linked Jira

🔗 Linked GitHub Issue

Fixes #

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

I have not used any AI assistance for this PR.
I have used AI assistance for this PR.

If you have used AI assistance, please provide the following details:

Which LLM was used?

Extent of AI Assistance:

Documentation and research only
Unit tests or E2E tests only
Code generation (parts of the code)
Full code generation (most of the PR)
PR description and comments
Commit message(s)

Important

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com

**💡You can use the script ./hack/add-llm-coauthor.sh to automatically add
these co-author trailers to your commits.

✅ Submitter Checklist

Split the single github_ghe CI matrix entry into github_ghe_1, github_ghe_2, and github_ghe_3 to run GHE E2E tests in parallel, matching the existing gitea chunking pattern. The old github_ghe target is kept as a backward compat alias. Signed-off-by: Zaki Shaikh <zashaikh@redhat.com> Assisted-by: Claude Opus 4.6 (via Claude Code)

gemini-code-assist · 2026-03-02T07:40:36Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the efficiency of the CI pipeline by introducing parallel execution for GitHub Enterprise end-to-end tests. By dividing the previously monolithic 'github_ghe' job into three concurrent segments, the overall feedback loop for GHE-related changes will be substantially reduced, leading to faster development cycles and improved resource utilization within the CI system.

Highlights

Parallelized GHE E2E Tests: The single 'github_ghe' CI job has been split into three parallel jobs ('github_ghe_1', 'github_ghe_2', 'github_ghe_3') to accelerate GitHub Enterprise end-to-end test execution.
Backward Compatibility: The original 'github_ghe' target is retained as an alias to ensure compatibility with existing workflows, alongside 'github_second_controller'.
Test Chunking Logic: New logic was introduced to calculate and distribute GHE tests into three distinct chunks, mirroring the existing Gitea test parallelization pattern.

Changelog

hack/gh-workflow-ci.sh
- Introduced a new array 'ghe_tests' to specifically filter and store GitHub Enterprise E2E tests.
- Modified the conditional check for 'github_tests' to correctly exclude the new 'github_ghe*' targets.
- Added logic to calculate 'ghe_chunk_size' and 'ghe_remainder' for distributing GHE tests into three parts.
- Updated the 'case' statement to handle the new 'github_ghe_1', 'github_ghe_2', and 'github_ghe_3' targets, each printing its respective chunk of GHE tests.
- Modified the 'github_second_controller' case to also act as a backward-compatible alias for 'github_ghe', printing all GHE tests.
- Updated the list of supported targets and backward compatibility aliases in the error message.
- Modified the 'print_tests' loop to iterate over the new 'github_ghe_1', 'github_ghe_2', 'github_ghe_3' targets.

Ignored Files

Ignored by pattern: .github/workflows/** (1)
- .github/workflows/e2e.yaml

Activity

No human activity has occurred on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

pipelines-as-code · 2026-03-02T07:41:00Z

🔍 PR Lint Feedback

Note: This automated check helps ensure your PR follows our contribution guidelines.

⚠️ Items that need attention:

🎫 Jira reference

Add a Jira reference in the description using one of the following formats:

https://issues.redhat.com/browse/SRVKP-<number>

If no SRVKP ticket exists yet, link a GitHub issue instead (e.g., Fixes #123).
Minor housekeeping PRs without Jira coverage can skip this after confirming with reviewers.

ℹ️ Next Steps

Review and address the items above
Push new commits to update this PR
This comment will be automatically updated when issues are resolved

🔧 Admin Tools (click to expand)

Automated Issue/Ticket Creation:

/issue-create - Generate a GitHub issue from this PR content using AI
/jira-create - Create a SRVKP Jira ticket from this PR content using AI

⚠️ Important: Always review and edit generated content before finalizing tickets/issues.
The AI-generated content should be used as a starting point and may need adjustments.

These commands are available to maintainers and will post the generated content as PR comments for review.

_{🤖 This feedback was generated automatically by the PR CI system}

gemini-code-assist

Code Review

This pull request splits the github_ghe E2E tests into three parallel chunks, which is a good improvement for CI performance. The implementation follows the existing pattern for gitea tests. I've left a few comments with suggestions to improve consistency and fix a potential bug related to how test lists are generated. Overall, the changes look good.

gemini-code-assist · 2026-03-02T07:43:08Z

hack/gh-workflow-ci.sh


+  local -a ghe_tests=()
+  if [[ "${target}" == github_ghe* ]]; then
+    mapfile -t ghe_tests < <(echo "${all_tests}" | grep -iP 'GithubGHE' 2>/dev/null | grep -ivP 'Concurrency' 2>/dev/null | sort 2>/dev/null)


With set -o pipefail active, this line will cause the script to exit if grep doesn't find any matching tests, because grep will exit with status 1. You should handle this case to avoid unexpected script failures. Appending || true after the grep pipeline is a common way to solve this.

This issue is pre-existing and also affects the creation of gitea_tests and github_tests.

Suggested change

mapfile -t ghe_tests < <(echo "${all_tests}" | grep -iP 'GithubGHE' 2>/dev/null | grep -ivP 'Concurrency' 2>/dev/null | sort 2>/dev/null)

mapfile -t ghe_tests < <(echo "${all_tests}" | grep -iP 'GithubGHE' 2>/dev/null | grep -ivP 'Concurrency' 2>/dev/null || true | sort 2>/dev/null)

gemini-code-assist · 2026-03-02T07:43:08Z

hack/gh-workflow-ci.sh

  fi

+  local -a ghe_tests=()
+  if [[ "${target}" == github_ghe* ]]; then


The ghe_tests array should also be populated for the github_second_controller target, as it's an alias for running GHE tests. This will allow you to reuse the ghe_tests array for the alias case, improving consistency and avoiding redundant computations. See my other comment on how to use this.

Suggested change

if [[ "${target}" == github_ghe* ]]; then

if [[ "${target}" == github_ghe* || "${target}" == "github_second_controller" ]]; then

gemini-code-assist · 2026-03-02T07:43:09Z

hack/gh-workflow-ci.sh

+  # pull_request_target runs the workflow YAML from main which still sends old
+  # target names.
+  github_second_controller | github_ghe)
    printf '%s\n' "${all_tests}" | grep -iP 'GithubGHE' | grep -ivP 'Concurrency'


After modifying the condition to populate ghe_tests for github_second_controller (as per my other suggestion), you can simplify this to use the ghe_tests array directly. This avoids re-running grep and ensures the output is sorted, which is consistent with the new chunked targets.

Suggested change

printf '%s\n' "${all_tests}" | grep -iP 'GithubGHE' | grep -ivP 'Concurrency'

printf '%s\n' "${ghe_tests[@]}"

zakisk requested a review from chmouel March 2, 2026 07:40

pipelines-as-code bot added ci testing labels Mar 2, 2026

gemini-code-assist bot reviewed Mar 2, 2026

View reviewed changes

theakshaypant approved these changes Mar 2, 2026

View reviewed changes

theakshaypant merged commit c057f26 into tektoncd:main Mar 2, 2026
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: split github_ghe job into 3 parallel chunks#2517

test: split github_ghe job into 3 parallel chunks#2517
theakshaypant merged 1 commit intotektoncd:mainfrom
zakisk:break-ghe-job-into-three

zakisk commented Mar 2, 2026

Uh oh!

gemini-code-assist bot commented Mar 2, 2026

Uh oh!

pipelines-as-code bot commented Mar 2, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Mar 2, 2026

Uh oh!

gemini-code-assist bot Mar 2, 2026

Uh oh!

gemini-code-assist bot Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	mapfile -t ghe_tests < <(echo "${all_tests}" \| grep -iP 'GithubGHE' 2>/dev/null \| grep -ivP 'Concurrency' 2>/dev/null \| sort 2>/dev/null)
	mapfile -t ghe_tests < <(echo "${all_tests}" \| grep -iP 'GithubGHE' 2>/dev/null \| grep -ivP 'Concurrency' 2>/dev/null \|\| true \| sort 2>/dev/null)

	if [[ "${target}" == github_ghe* ]]; then
	if [[ "${target}" == github_ghe* \|\| "${target}" == "github_second_controller" ]]; then

	printf '%s\n' "${all_tests}" \| grep -iP 'GithubGHE' \| grep -ivP 'Concurrency'
	printf '%s\n' "${ghe_tests[@]}"

Conversation

zakisk commented Mar 2, 2026

📝 Description of the Change

👨🏻‍ Linked Jira

🔗 Linked GitHub Issue

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

✅ Submitter Checklist

Uh oh!

gemini-code-assist bot commented Mar 2, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

pipelines-as-code bot commented Mar 2, 2026

🔍 PR Lint Feedback

⚠️ Items that need attention:

🎫 Jira reference

ℹ️ Next Steps

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants