fix: Correct type for status options by chmouel · Pull Request #2499 · tektoncd/pipelines-as-code

chmouel · 2026-02-23T16:57:43Z

The formatPipelineComment function received the statusOpts parameter with the incorrect type. This commit corrects the type to providerstatus.StatusOpts to ensure type safety and proper function execution.

📝 Description of the Change

👨🏻‍ Linked Jira

🔗 Linked GitHub Issue

Fixes #

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

I have not used any AI assistance for this PR.
I have used AI assistance for this PR.

If you have used AI assistance, please provide the following details:

Which LLM was used?

Extent of AI Assistance:

Documentation and research only
Unit tests or E2E tests only
Code generation (parts of the code)
Full code generation (most of the PR)
PR description and comments
Commit message(s)

Important

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com

**💡You can use the script ./hack/add-llm-coauthor.sh to automatically add
these co-author trailers to your commits.

✅ Submitter Checklist

The `formatPipelineComment` function received the `statusOpts` parameter with the incorrect type. This commit corrects the type to `providerstatus.StatusOpts` to ensure type safety and proper function execution.

gemini-code-assist · 2026-02-23T16:57:55Z

Summary of Changes

Hello @chmouel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a type mismatch within the formatPipelineComment function in the GitHub provider. By updating the statusOpts parameter to its correct type, providerstatus.StatusOpts, the change significantly improves type safety and reliability for pipeline status formatting operations.

Highlights

Type Correction: Corrected the type of the status parameter in the formatPipelineComment function from provider.StatusOpts to providerstatus.StatusOpts to enhance type safety and ensure proper function execution.

Changelog

pkg/provider/github/status.go
- Updated the type of the status parameter in the formatPipelineComment function to providerstatus.StatusOpts.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

pipelines-as-code · 2026-02-23T16:58:07Z

🔍 PR Lint Feedback

Note: This automated check helps ensure your PR follows our contribution guidelines.

⚠️ Items that need attention:

🎫 Jira reference

Add a Jira reference in the description using one of the following formats:

https://issues.redhat.com/browse/SRVKP-<number>

If no SRVKP ticket exists yet, link a GitHub issue instead (e.g., Fixes #123).
Minor housekeeping PRs without Jira coverage can skip this after confirming with reviewers.

🤖 AI attribution

The following commits lack an explicit AI attribution footer:

57ed91f fix: Correct type for status options

If no AI assistance was used for a commit, you can ignore this warning.
Otherwise add an Assisted-by: or Co-authored-by: footer referencing the AI used.

ℹ️ Next Steps

Review and address the items above
Push new commits to update this PR
This comment will be automatically updated when issues are resolved

🔧 Admin Tools (click to expand)

Automated Issue/Ticket Creation:

/issue-create - Generate a GitHub issue from this PR content using AI
/jira-create - Create a SRVKP Jira ticket from this PR content using AI

⚠️ Important: Always review and edit generated content before finalizing tickets/issues.
The AI-generated content should be used as a starting point and may need adjustments.

These commands are available to maintainers and will post the generated content as PR comments for review.

_{🤖 This feedback was generated automatically by the PR CI system}

Copilot

Pull request overview

This PR fixes a type error in the formatPipelineComment function signature by correcting the parameter type from the non-existent provider.StatusOpts to the correct providerstatus.StatusOpts. This ensures type safety and proper compilation. The StatusOpts type is defined in the pkg/provider/status package (aliased as providerstatus in this file), not in the pkg/provider package itself.

Changes:

Corrected the status parameter type in formatPipelineComment from provider.StatusOpts to providerstatus.StatusOpts

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

gemini-code-assist

Code Review

The pull request correctly identifies and fixes a type mismatch in the formatPipelineComment function signature. By changing the parameter type from provider.StatusOpts to providerstatus.StatusOpts, the code now correctly references the intended type definition and maintains consistency with other status-related functions in the same file. This change ensures type safety and prevents potential compilation issues.

fix: Correct type for status options

57ed91f

The `formatPipelineComment` function received the `statusOpts` parameter with the incorrect type. This commit corrects the type to `providerstatus.StatusOpts` to ensure type safety and proper function execution.

Copilot AI review requested due to automatic review settings February 23, 2026 16:57

pipelines-as-code bot added fix github go Pull requests that update Go code labels Feb 23, 2026

Copilot started reviewing on behalf of chmouel February 23, 2026 16:58 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

gemini-code-assist bot reviewed Feb 23, 2026

View reviewed changes

chmouel merged commit efe2e0e into tektoncd:main Feb 23, 2026
15 checks passed

chmouel deleted the refactor-status-opts-type branch February 23, 2026 17:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Correct type for status options#2499

fix: Correct type for status options#2499
chmouel merged 1 commit intotektoncd:mainfrom
chmouel:refactor-status-opts-type

chmouel commented Feb 23, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 23, 2026

Uh oh!

pipelines-as-code bot commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

chmouel commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description of the Change

👨🏻‍ Linked Jira

🔗 Linked GitHub Issue

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

✅ Submitter Checklist

Uh oh!

gemini-code-assist bot commented Feb 23, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

pipelines-as-code bot commented Feb 23, 2026

🔍 PR Lint Feedback

⚠️ Items that need attention:

🎫 Jira reference

🤖 AI attribution

ℹ️ Next Steps

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chmouel commented Feb 23, 2026 •

edited

Loading