fix: Move to gitlab.pipelinesascode.com for e2e#2492
Conversation
Move to gitlab.pipelinesascode.com for e2e testing, as gitlab.com is not working well with our e2e tests and we have seen a lot of timeouts and other issues. This should help us to have more stable e2e tests and also to have more control over the environment where we run our tests.
Summary of ChangesHello @chmouel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the reliability of end-to-end tests by migrating the GitLab testing environment. The change specifically targets the GitLab API URL used in CI workflows, moving to a dedicated domain to mitigate previous stability concerns and provide a more controlled testing infrastructure. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This pull request updates the GitLab API URL configuration for end-to-end (e2e) testing from https://gitlab.com to https://gitlab.pipelinesascode.com. According to the PR description, this change is motivated by reliability issues with gitlab.com during e2e testing, including timeouts and other problems. Moving to a dedicated gitlab.pipelinesascode.com instance should provide more stable testing and better control over the test environment.
Changes:
- Updated the GitLab API URL environment variable in the GitHub Actions CI script to use the new instance
- Removed the hardcoded GitLab API URL from the GitHub Actions e2e workflow configuration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hack/gh-workflow-ci.sh | Exports TEST_GITLAB_API_URL environment variable set to the new gitlab.pipelinesascode.com URL |
| .github/workflows/e2e.yaml | Removes the hardcoded TEST_GITLAB_API_URL environment variable that was previously set to gitlab.com |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request updates the CI configuration to use gitlab.pipelinesascode.com for GitLab end-to-end tests. The change introduces a new environment variable, TEST_GITLAB_API_URL, in the gh-workflow-ci.sh script to specify the new test endpoint. This is a straightforward and effective way to redirect the e2e tests to a more stable, dedicated environment, as described in the pull request. The implementation is correct and I have no further comments.
|
gitlab is green which is good enough merging |
Move to gitlab.pipelinesascode.com for e2e testing, as gitlab.com is not working well with our e2e tests and we have seen a lot of timeouts and other issues. This should help us to have more stable e2e tests and also to have more control over the environment where we run our tests.
📝 Description of the Change
👨🏻 Linked Jira
🔗 Linked GitHub Issue
Fixes #
🚀 Type of Change
fix:)feat:)feat!:,fix!:)docs:)chore:)refactor:)enhance:)deps:)🧪 Testing Strategy
🤖 AI Assistance
If you have used AI assistance, please provide the following details:
Which LLM was used?
Extent of AI Assistance:
Important
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com
**💡You can use the script
./hack/add-llm-coauthor.shto automatically addthese co-author trailers to your commits.
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.