Skip to content

fix: Skip Bitbucket Datacenter tests temporarily#2475

Merged
chmouel merged 1 commit intotektoncd:mainfrom
chmouel:skip-bitbucket-datacenter-tests
Feb 12, 2026
Merged

fix: Skip Bitbucket Datacenter tests temporarily#2475
chmouel merged 1 commit intotektoncd:mainfrom
chmouel:skip-bitbucket-datacenter-tests

Conversation

@chmouel
Copy link
Copy Markdown
Member

@chmouel chmouel commented Feb 12, 2026

The Bitbucket Datacenter tests were skipped because the Bitbucket infrastructure is currently unavailable. This commit adds skip directives to the relevant test functions.

📝 Description of the Change

👨🏻‍ Linked Jira

🔗 Linked GitHub Issue

Fixes #

🚀 Type of Change

  • 🐛 Bug fix (fix:)
  • ✨ New feature (feat:)
  • 💥 Breaking change (feat!:, fix!:)
  • 📚 Documentation update (docs:)
  • ⚙️ Chore (chore:)
  • 💅 Refactor (refactor:)
  • 🔧 Enhancement (enhance:)
  • 📦 Dependency update (deps:)

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

If you have used AI assistance, please provide the following details:

Which LLM was used?

  • GitHub Copilot
  • ChatGPT (OpenAI)
  • Claude (Anthropic)
  • Cursor
  • Gemini (Google)
  • Other: ____________

Extent of AI Assistance:

  • Documentation and research only
  • Unit tests or E2E tests only
  • Code generation (parts of the code)
  • Full code generation (most of the PR)
  • PR description and comments
  • Commit message(s)

Important

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com

**💡You can use the script ./hack/add-llm-coauthor.sh to automatically add
these co-author trailers to your commits.

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

The Bitbucket Datacenter tests were skipped because the Bitbucket
infrastructure is currently unavailable. This commit adds skip
directives to the relevant test functions.
Copilot AI review requested due to automatic review settings February 12, 2026 13:42
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @chmouel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces temporary skips for several Bitbucket Datacenter end-to-end tests. The primary motivation is to prevent continuous integration pipelines from failing due to an external dependency, specifically the Bitbucket infrastructure, which is currently experiencing unavailability. By adding t.Skip() directives, the tests are bypassed without being removed, allowing the CI to pass while the infrastructure issue is resolved.

Highlights

  • Temporary Test Skipping: Bitbucket Datacenter end-to-end tests have been temporarily skipped due to the unavailability of the Bitbucket infrastructure.
  • Impact on CI: This change prevents CI failures that would otherwise occur due to external service dependencies.
Changelog
  • test/bitbucket_datacenter_dynamic_variables_test.go
    • Added a t.Skip() call to TestBitbucketDataCenterDynamicVariables.
  • test/bitbucket_datacenter_pull_request_test.go
    • Added a t.Skip() call to TestBitbucketDataCenterPullRequest.
    • Added a t.Skip() call to TestBitbucketDataCenterCELPathChangeInPullRequest.
  • test/bitbucket_datacenter_push_test.go
    • Added a t.Skip() call to TestBitbucketDataCenterCELPathChangeOnPush.
Activity
  • The pull request was created by chmouel to address failing Bitbucket Datacenter tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@chmouel chmouel merged commit 982d3af into tektoncd:main Feb 12, 2026
9 of 13 checks passed
@chmouel chmouel deleted the skip-bitbucket-datacenter-tests branch February 12, 2026 13:43
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request temporarily disables Bitbucket Datacenter tests by adding t.Skip() to them. The changes are straightforward and achieve the stated goal. I've pointed out a minor typo in the skip messages across the modified files. Please correct it for clarity.

)

func TestBitbucketDataCenterDynamicVariables(t *testing.T) {
t.Skip("skipping test for now, until we ge the bitbucket infra back")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a typo in the skip message. "ge" should be "get".

Suggested change
t.Skip("skipping test for now, until we ge the bitbucket infra back")
t.Skip("skipping test for now, until we get the bitbucket infra back")

)

func TestBitbucketDataCenterPullRequest(t *testing.T) {
t.Skip("skipping test for now, until we ge the bitbucket infra back")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a typo in the skip message. "ge" should be "get".

Suggested change
t.Skip("skipping test for now, until we ge the bitbucket infra back")
t.Skip("skipping test for now, until we get the bitbucket infra back")

}

func TestBitbucketDataCenterCELPathChangeInPullRequest(t *testing.T) {
t.Skip("skipping test for now, until we ge the bitbucket infra back")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a typo in the skip message. "ge" should be "get".

Suggested change
t.Skip("skipping test for now, until we ge the bitbucket infra back")
t.Skip("skipping test for now, until we get the bitbucket infra back")

)

func TestBitbucketDataCenterCELPathChangeOnPush(t *testing.T) {
t.Skip("skipping test for now, until we ge the bitbucket infra back")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a typo in the skip message. "ge" should be "get".

Suggested change
t.Skip("skipping test for now, until we ge the bitbucket infra back")
t.Skip("skipping test for now, until we get the bitbucket infra back")

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Temporarily disables Bitbucket Data Center E2E tests by adding t.Skip(...) calls at the start of the relevant test functions, due to current Bitbucket infrastructure unavailability.

Changes:

  • Added t.Skip(...) to Bitbucket Data Center push E2E test.
  • Added t.Skip(...) to Bitbucket Data Center pull request E2E tests.
  • Added t.Skip(...) to Bitbucket Data Center dynamic variables E2E test.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File Description
test/bitbucket_datacenter_push_test.go Unconditionally skips the Bitbucket DC push-related E2E test.
test/bitbucket_datacenter_pull_request_test.go Unconditionally skips the Bitbucket DC PR-related E2E tests.
test/bitbucket_datacenter_dynamic_variables_test.go Unconditionally skips the Bitbucket DC dynamic variables E2E test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

)

func TestBitbucketDataCenterPullRequest(t *testing.T) {
t.Skip("skipping test for now, until we ge the bitbucket infra back")
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unconditional t.Skip, which will keep these Bitbucket Data Center E2E tests permanently disabled even after the infra comes back. Consider guarding the skip behind an env flag (similar to NIGHTLY_E2E_TEST), or skipping only when an actual connectivity/setup check fails, and include a tracking issue reference in the skip message so it’s not forgotten.

Copilot uses AI. Check for mistakes.
}

func TestBitbucketDataCenterCELPathChangeInPullRequest(t *testing.T) {
t.Skip("skipping test for now, until we ge the bitbucket infra back")
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skip message has a typo ("ge") and reads a bit unclear. Please correct it (e.g., "get") so the reason is understandable in test output/logs.

Copilot uses AI. Check for mistakes.
}

func TestBitbucketDataCenterCELPathChangeInPullRequest(t *testing.T) {
t.Skip("skipping test for now, until we ge the bitbucket infra back")
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unconditional t.Skip, which will keep these Bitbucket Data Center E2E tests permanently disabled even after the infra comes back. Consider guarding the skip behind an env flag (similar to NIGHTLY_E2E_TEST), or skipping only when an actual connectivity/setup check fails, and include a tracking issue reference in the skip message so it’s not forgotten.

Copilot uses AI. Check for mistakes.
)

func TestBitbucketDataCenterDynamicVariables(t *testing.T) {
t.Skip("skipping test for now, until we ge the bitbucket infra back")
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skip message has a typo ("ge") and reads a bit unclear. Please correct it (e.g., "get") so the reason is understandable in test output/logs.

Suggested change
t.Skip("skipping test for now, until we ge the bitbucket infra back")
t.Skip("skipping test for now, until we get the bitbucket infra back")

Copilot uses AI. Check for mistakes.
)

func TestBitbucketDataCenterDynamicVariables(t *testing.T) {
t.Skip("skipping test for now, until we ge the bitbucket infra back")
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unconditional t.Skip, which will keep these Bitbucket Data Center E2E tests permanently disabled even after the infra comes back. Consider guarding the skip behind an env flag (similar to NIGHTLY_E2E_TEST), or skipping only when an actual connectivity/setup check fails, and include a tracking issue reference in the skip message so it’s not forgotten.

Suggested change
t.Skip("skipping test for now, until we ge the bitbucket infra back")
if os.Getenv("BITBUCKET_E2E_ENABLE") != "true" {
t.Skip("skipping Bitbucket Data Center E2E test until infra is restored; set BITBUCKET_E2E_ENABLE=true to run (see issue #1234)")
}

Copilot uses AI. Check for mistakes.
)

func TestBitbucketDataCenterCELPathChangeOnPush(t *testing.T) {
t.Skip("skipping test for now, until we ge the bitbucket infra back")
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skip message has a typo ("ge") and reads a bit unclear. Please correct it (e.g., "get") so the reason is understandable in test output/logs.

Suggested change
t.Skip("skipping test for now, until we ge the bitbucket infra back")
t.Skip("skipping test for now until we get the Bitbucket infrastructure back")

Copilot uses AI. Check for mistakes.
)

func TestBitbucketDataCenterCELPathChangeOnPush(t *testing.T) {
t.Skip("skipping test for now, until we ge the bitbucket infra back")
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unconditional t.Skip, which will keep these Bitbucket Data Center E2E tests permanently disabled even after the infra comes back. Consider guarding the skip behind an env flag (similar to NIGHTLY_E2E_TEST), or skipping only when an actual connectivity/setup check fails, and include a tracking issue reference in the skip message so it’s not forgotten.

Suggested change
t.Skip("skipping test for now, until we ge the bitbucket infra back")
if os.Getenv("NIGHTLY_E2E_TEST") == "" {
t.Skip("Bitbucket Data Center E2E test temporarily disabled until infra is back; set NIGHTLY_E2E_TEST=1 to run. Tracking: https://github.com/openshift-pipelines/pipelines-as-code/issues/0000")
}

Copilot uses AI. Check for mistakes.
)

func TestBitbucketDataCenterPullRequest(t *testing.T) {
t.Skip("skipping test for now, until we ge the bitbucket infra back")
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skip message has a typo ("ge") and reads a bit unclear. Please correct it (e.g., "get") so the reason is understandable in test output/logs.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants