fix: Skip Bitbucket Datacenter tests temporarily#2475
Conversation
The Bitbucket Datacenter tests were skipped because the Bitbucket infrastructure is currently unavailable. This commit adds skip directives to the relevant test functions.
Summary of ChangesHello @chmouel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces temporary skips for several Bitbucket Datacenter end-to-end tests. The primary motivation is to prevent continuous integration pipelines from failing due to an external dependency, specifically the Bitbucket infrastructure, which is currently experiencing unavailability. By adding Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request temporarily disables Bitbucket Datacenter tests by adding t.Skip() to them. The changes are straightforward and achieve the stated goal. I've pointed out a minor typo in the skip messages across the modified files. Please correct it for clarity.
| ) | ||
|
|
||
| func TestBitbucketDataCenterDynamicVariables(t *testing.T) { | ||
| t.Skip("skipping test for now, until we ge the bitbucket infra back") |
| ) | ||
|
|
||
| func TestBitbucketDataCenterPullRequest(t *testing.T) { | ||
| t.Skip("skipping test for now, until we ge the bitbucket infra back") |
| } | ||
|
|
||
| func TestBitbucketDataCenterCELPathChangeInPullRequest(t *testing.T) { | ||
| t.Skip("skipping test for now, until we ge the bitbucket infra back") |
| ) | ||
|
|
||
| func TestBitbucketDataCenterCELPathChangeOnPush(t *testing.T) { | ||
| t.Skip("skipping test for now, until we ge the bitbucket infra back") |
There was a problem hiding this comment.
Pull request overview
Temporarily disables Bitbucket Data Center E2E tests by adding t.Skip(...) calls at the start of the relevant test functions, due to current Bitbucket infrastructure unavailability.
Changes:
- Added
t.Skip(...)to Bitbucket Data Center push E2E test. - Added
t.Skip(...)to Bitbucket Data Center pull request E2E tests. - Added
t.Skip(...)to Bitbucket Data Center dynamic variables E2E test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| test/bitbucket_datacenter_push_test.go | Unconditionally skips the Bitbucket DC push-related E2E test. |
| test/bitbucket_datacenter_pull_request_test.go | Unconditionally skips the Bitbucket DC PR-related E2E tests. |
| test/bitbucket_datacenter_dynamic_variables_test.go | Unconditionally skips the Bitbucket DC dynamic variables E2E test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
|
|
||
| func TestBitbucketDataCenterPullRequest(t *testing.T) { | ||
| t.Skip("skipping test for now, until we ge the bitbucket infra back") |
There was a problem hiding this comment.
This is an unconditional t.Skip, which will keep these Bitbucket Data Center E2E tests permanently disabled even after the infra comes back. Consider guarding the skip behind an env flag (similar to NIGHTLY_E2E_TEST), or skipping only when an actual connectivity/setup check fails, and include a tracking issue reference in the skip message so it’s not forgotten.
| } | ||
|
|
||
| func TestBitbucketDataCenterCELPathChangeInPullRequest(t *testing.T) { | ||
| t.Skip("skipping test for now, until we ge the bitbucket infra back") |
There was a problem hiding this comment.
The skip message has a typo ("ge") and reads a bit unclear. Please correct it (e.g., "get") so the reason is understandable in test output/logs.
| } | ||
|
|
||
| func TestBitbucketDataCenterCELPathChangeInPullRequest(t *testing.T) { | ||
| t.Skip("skipping test for now, until we ge the bitbucket infra back") |
There was a problem hiding this comment.
This is an unconditional t.Skip, which will keep these Bitbucket Data Center E2E tests permanently disabled even after the infra comes back. Consider guarding the skip behind an env flag (similar to NIGHTLY_E2E_TEST), or skipping only when an actual connectivity/setup check fails, and include a tracking issue reference in the skip message so it’s not forgotten.
| ) | ||
|
|
||
| func TestBitbucketDataCenterDynamicVariables(t *testing.T) { | ||
| t.Skip("skipping test for now, until we ge the bitbucket infra back") |
There was a problem hiding this comment.
The skip message has a typo ("ge") and reads a bit unclear. Please correct it (e.g., "get") so the reason is understandable in test output/logs.
| t.Skip("skipping test for now, until we ge the bitbucket infra back") | |
| t.Skip("skipping test for now, until we get the bitbucket infra back") |
| ) | ||
|
|
||
| func TestBitbucketDataCenterDynamicVariables(t *testing.T) { | ||
| t.Skip("skipping test for now, until we ge the bitbucket infra back") |
There was a problem hiding this comment.
This is an unconditional t.Skip, which will keep these Bitbucket Data Center E2E tests permanently disabled even after the infra comes back. Consider guarding the skip behind an env flag (similar to NIGHTLY_E2E_TEST), or skipping only when an actual connectivity/setup check fails, and include a tracking issue reference in the skip message so it’s not forgotten.
| t.Skip("skipping test for now, until we ge the bitbucket infra back") | |
| if os.Getenv("BITBUCKET_E2E_ENABLE") != "true" { | |
| t.Skip("skipping Bitbucket Data Center E2E test until infra is restored; set BITBUCKET_E2E_ENABLE=true to run (see issue #1234)") | |
| } |
| ) | ||
|
|
||
| func TestBitbucketDataCenterCELPathChangeOnPush(t *testing.T) { | ||
| t.Skip("skipping test for now, until we ge the bitbucket infra back") |
There was a problem hiding this comment.
The skip message has a typo ("ge") and reads a bit unclear. Please correct it (e.g., "get") so the reason is understandable in test output/logs.
| t.Skip("skipping test for now, until we ge the bitbucket infra back") | |
| t.Skip("skipping test for now until we get the Bitbucket infrastructure back") |
| ) | ||
|
|
||
| func TestBitbucketDataCenterCELPathChangeOnPush(t *testing.T) { | ||
| t.Skip("skipping test for now, until we ge the bitbucket infra back") |
There was a problem hiding this comment.
This is an unconditional t.Skip, which will keep these Bitbucket Data Center E2E tests permanently disabled even after the infra comes back. Consider guarding the skip behind an env flag (similar to NIGHTLY_E2E_TEST), or skipping only when an actual connectivity/setup check fails, and include a tracking issue reference in the skip message so it’s not forgotten.
| t.Skip("skipping test for now, until we ge the bitbucket infra back") | |
| if os.Getenv("NIGHTLY_E2E_TEST") == "" { | |
| t.Skip("Bitbucket Data Center E2E test temporarily disabled until infra is back; set NIGHTLY_E2E_TEST=1 to run. Tracking: https://github.com/openshift-pipelines/pipelines-as-code/issues/0000") | |
| } |
| ) | ||
|
|
||
| func TestBitbucketDataCenterPullRequest(t *testing.T) { | ||
| t.Skip("skipping test for now, until we ge the bitbucket infra back") |
There was a problem hiding this comment.
The skip message has a typo ("ge") and reads a bit unclear. Please correct it (e.g., "get") so the reason is understandable in test output/logs.
The Bitbucket Datacenter tests were skipped because the Bitbucket infrastructure is currently unavailable. This commit adds skip directives to the relevant test functions.
📝 Description of the Change
👨🏻 Linked Jira
🔗 Linked GitHub Issue
Fixes #
🚀 Type of Change
fix:)feat:)feat!:,fix!:)docs:)chore:)refactor:)enhance:)deps:)🧪 Testing Strategy
🤖 AI Assistance
If you have used AI assistance, please provide the following details:
Which LLM was used?
Extent of AI Assistance:
Important
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com
**💡You can use the script
./hack/add-llm-coauthor.shto automatically addthese co-author trailers to your commits.
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.