fix: use correct dir to store ghe gosmee payloads by zakisk · Pull Request #2463 · tektoncd/pipelines-as-code

zakisk · 2026-02-11T04:21:51Z

in e2e output payloads directory we're checking /tmp/gosmee-replay-ghe directory but in second-controller.py script we're saving paylaods in /tmp/save directory and that's why on downloading failed e2e artifacts we have no ghe gosmme payloads stored in it. this commit uses correct directory to check for payloads.

📝 Description of the Change

👨🏻‍ Linked Jira

🔗 Linked GitHub Issue

Fixes #

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

I have not used any AI assistance for this PR.
I have used AI assistance for this PR.

If you have used AI assistance, please provide the following details:

Which LLM was used?

Extent of AI Assistance:

Documentation and research only
Unit tests or E2E tests only
Code generation (parts of the code)
Full code generation (most of the PR)
PR description and comments
Commit message(s)

Important

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com

**💡You can use the script ./hack/add-llm-coauthor.sh to automatically add
these co-author trailers to your commits.

✅ Submitter Checklist

in e2e output payloads directory we're checking /tmp/gosmee-replay-ghe directory but in second-controller.py script we're saving paylaods in /tmp/save directory and that's why on downloading failed e2e artifacts we have no ghe gosmme payloads stored in it. this commit uses correct directory to check for payloads. Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>

pipelines-as-code · 2026-02-11T04:22:29Z

🔍 PR Lint Feedback

Note: This automated check helps ensure your PR follows our contribution guidelines.

⚠️ Items that need attention:

🎫 Jira reference

Add a Jira reference in the description using one of the following formats:

https://issues.redhat.com/browse/SRVKP-<number>

If no SRVKP ticket exists yet, link a GitHub issue instead (e.g., Fixes #123).
Minor housekeeping PRs without Jira coverage can skip this after confirming with reviewers.

🤖 AI attribution

The following commits lack an explicit AI attribution footer:

5f76d83 fix: use correct dir to store ghe gosmee payloads

If no AI assistance was used for a commit, you can ignore this warning.
Otherwise add an Assisted-by: or Co-authored-by: footer referencing the AI used.

ℹ️ Next Steps

Review and address the items above
Push new commits to update this PR
This comment will be automatically updated when issues are resolved

🔧 Admin Tools (click to expand)

Automated Issue/Ticket Creation:

/issue-create - Generate a GitHub issue from this PR content using AI
/jira-create - Create a SRVKP Jira ticket from this PR content using AI

⚠️ Important: Always review and edit generated content before finalizing tickets/issues.
The AI-generated content should be used as a starting point and may need adjustments.

These commands are available to maintainers and will post the generated content as PR comments for review.

_{🤖 This feedback was generated automatically by the PR CI system}

gemini-code-assist · 2026-02-11T04:22:38Z

Summary of Changes

Hello @zakisk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug in the end-to-end testing infrastructure where gosmee payloads were being saved to an incorrect temporary directory. By updating the second-controller.py script to use the correct path, it ensures that these payloads are properly stored and accessible for debugging and analysis of failed e2e tests, improving the reliability of artifact collection.

Highlights

Payload Storage Fix: Corrected the directory path for storing gosmee payloads in the second-controller.py script to ensure they are saved to the expected /tmp/gosmee-replay-ghe location, resolving issues with e2e artifact collection.

Changelog

hack/second-controller.py
- Updated the --saveDir argument for gosmee to use /tmp/gosmee-replay-ghe instead of /tmp/save.

Activity

No human activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly fixes a bug by updating the directory for gosmee payloads, ensuring E2E tests can find them. The change is straightforward and effective. I've included a suggestion to improve the script's maintainability by using PyYAML for all YAML generation, which would make the code more robust and consistent.

zakisk requested a review from chmouel February 11, 2026 04:21

pipelines-as-code bot added the fix label Feb 11, 2026

gemini-code-assist bot reviewed Feb 11, 2026

View reviewed changes

chmouel approved these changes Feb 11, 2026

View reviewed changes

zakisk merged commit 198f654 into tektoncd:main Feb 11, 2026
2 checks passed

zakisk deleted the fix-ghe-replys-in-e2e-output-artifacts branch February 11, 2026 06:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use correct dir to store ghe gosmee payloads#2463

fix: use correct dir to store ghe gosmee payloads#2463
zakisk merged 1 commit intotektoncd:mainfrom
zakisk:fix-ghe-replys-in-e2e-output-artifacts

zakisk commented Feb 11, 2026

Uh oh!

pipelines-as-code bot commented Feb 11, 2026

Uh oh!

gemini-code-assist bot commented Feb 11, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

zakisk commented Feb 11, 2026

📝 Description of the Change

👨🏻‍ Linked Jira

🔗 Linked GitHub Issue

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

✅ Submitter Checklist

Uh oh!

pipelines-as-code bot commented Feb 11, 2026

🔍 PR Lint Feedback

⚠️ Items that need attention:

🎫 Jira reference

🤖 AI attribution

ℹ️ Next Steps

Uh oh!

gemini-code-assist bot commented Feb 11, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants