fix: use random generated namespace in TestOthersRepositoryCreation#2458
fix: use random generated namespace in TestOthersRepositoryCreation#2458chmouel merged 1 commit intotektoncd:mainfrom
Conversation
e2e test TestOthersRepositoryCreation was failing because constant namespace name was used 'test-repo' in it which was sometime giving already exist namespace. Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
Summary of ChangesHello @zakisk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an intermittent failure in the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a flaky e2e test by replacing hardcoded namespace names with randomly generated ones. The approach is correct and effectively solves the problem of potential namespace conflicts during concurrent test runs. The suggestion to further improve the consistency and robustness of the test code by randomizing the repository name is valid and has been retained.
| targetNsNew := names.SimpleNameGenerator.RestrictLengthWithRandomSuffix("test-repo-new") | ||
| repo.Name = "test-repo-new" |
There was a problem hiding this comment.
For consistency and to make the test more robust, the repository name should also use the newly generated random name. Currently, targetNsNew is randomized, but repo.Name is assigned a hardcoded value. This is inconsistent with how targetNs is used for the repository name in the first part of the test.
| targetNsNew := names.SimpleNameGenerator.RestrictLengthWithRandomSuffix("test-repo-new") | |
| repo.Name = "test-repo-new" | |
| targetNsNew := names.SimpleNameGenerator.RestrictLengthWithRandomSuffix("test-repo-new") | |
| repo.Name = targetNsNew |
e2e test TestOthersRepositoryCreation was failing because constant namespace name was used 'test-repo' in it which was sometime giving already exist namespace.
📝 Description of the Change
👨🏻 Linked Jira
🔗 Linked GitHub Issue
Fixes #
🚀 Type of Change
fix:)feat:)feat!:,fix!:)docs:)chore:)refactor:)enhance:)deps:)🧪 Testing Strategy
🤖 AI Assistance
If you have used AI assistance, please provide the following details:
Which LLM was used?
Extent of AI Assistance:
Important
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com
**💡You can use the script
./hack/add-llm-coauthor.shto automatically addthese co-author trailers to your commits.
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.