test: Update git-clone StepAction to tekton v1beta1#2450
test: Update git-clone StepAction to tekton v1beta1#2450chmouel merged 1 commit intotektoncd:mainfrom
Conversation
Changed the apiVersion of the git-clone StepAction from tekton.dev/v1alpha1 to tekton.dev/v1beta1. This was done to align with the current stable API version for Tekton resources.
|
❌ PR-Agent failed to apply 'global' repo settings The configuration file needs to be a valid TOML, please fix it. Error message: Configuration content:[github_app]
pr_commands = [ "/review" ]
[pr_reviewer]
enable_review_labels_security = true
enable_chat_in_code_suggestions=false
enable_chat_in_code_suggestions = false
enable_summary=false
enable_help_text=false
[pr_description]
publish_description_as_comment = true
[pr_code_suggestions]
commitable_code_suggestions = true
[pr_test]
num_tests = 0 |
Summary of ChangesHello @chmouel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🔍 PR Lint Feedback
|
There was a problem hiding this comment.
Pull request overview
This PR updates the git-clone StepAction API version from tekton.dev/v1alpha1 to tekton.dev/v1beta1, aligning it with the current stable API version for Tekton StepAction resources and making it consistent with other StepAction files in the repository.
Changes:
- Updated apiVersion from
tekton.dev/v1alpha1totekton.dev/v1beta1 - Standardized YAML indentation for the env section
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,4 @@ | |||
| apiVersion: tekton.dev/v1alpha1 | |||
| apiVersion: tekton.dev/v1beta1 | |||
There was a problem hiding this comment.
The PR title begins with "test:" suggesting this is a test-related change, but this file is not a test file - it's a StepAction definition that is used by test pipelines. The PR title should more accurately reflect the nature of the change, such as "chore: Update git-clone StepAction to tekton v1beta1" or "feat: Migrate git-clone StepAction from v1alpha1 to v1beta1". According to the PR description template, the type of change should match the commit message prefix.
There was a problem hiding this comment.
Code Review
This pull request correctly updates the git-clone StepAction to use apiVersion: tekton.dev/v1beta1, aligning with the stable Tekton API. Additionally, it fixes an indentation issue in the env section, ensuring the YAML is valid. I've found one minor improvement opportunity regarding a quoted parameter value that should be addressed. Otherwise, the changes are straightforward and correct.
| - name: HOME | ||
| value: "$(params.userHome)" |
There was a problem hiding this comment.
The value for the HOME environment variable is quoted. Tekton's parameter substitution will result in the HOME variable being set to a string that includes the quotes (e.g., "/tekton/home" instead of /tekton/home). This is likely not the intended behavior and could cause issues with tools that expect a clean path in the HOME variable. It should be unquoted to match the style of other parameter substitutions in this file.
- name: HOME
value: $(params.userHome)
Changed the apiVersion of the git-clone StepAction from tekton.dev/v1alpha1 to tekton.dev/v1beta1. This was done to align with the current stable API version for Tekton resources.
📝 Description of the Change
👨🏻 Linked Jira
🔗 Linked GitHub Issue
Fixes #
🚀 Type of Change
fix:)feat:)feat!:,fix!:)docs:)chore:)refactor:)enhance:)deps:)🧪 Testing Strategy
🤖 AI Assistance
If you have used AI assistance, please provide the following details:
Which LLM was used?
Extent of AI Assistance:
Important
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com
**💡You can use the script
./hack/add-llm-coauthor.shto automatically addthese co-author trailers to your commits.
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.