fix: Rename golden file for flaky pull request test by chmouel · Pull Request #2449 · tektoncd/pipelines-as-code

chmouel · 2026-02-05T06:30:03Z

Renamed a golden file to better reflect its purpose in testing flaky
pull requests. This change improves the clarity and organization of test
data.

Renamed a golden file to better reflect its purpose in testing flaky pull requests. This change improves the clarity and organization of test data.

qodo-code-review · 2026-02-05T06:30:09Z

❌ PR-Agent failed to apply 'global' repo settings

The configuration file needs to be a valid TOML, please fix it.

Error message:
cannot access local variable 'file_data' where it is not associated with a value

Configuration content:

[github_app]
pr_commands = [ "/review" ]

[pr_reviewer]
enable_review_labels_security = true
enable_chat_in_code_suggestions=false
enable_chat_in_code_suggestions = false
enable_summary=false
enable_help_text=false

[pr_description]
publish_description_as_comment = true

[pr_code_suggestions]
commitable_code_suggestions = true

[pr_test]
num_tests = 0

gemini-code-assist · 2026-02-05T06:30:13Z

Summary of Changes

Hello @chmouel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the clarity and organization of test data by renaming a specific golden file. The change ensures that the test file's name precisely indicates its role in testing scenarios involving flaky pull requests, thereby enhancing maintainability and understanding for future test development.

Highlights

Test File Renaming: Renamed the golden test file TestGithubSecondPullRequestBadYaml.golden to TestGithubSecondFlakyPullRequestBadYaml.golden to more accurately reflect its purpose in testing flaky pull requests.

Changelog

test/testdata/TestGithubSecondPullRequestBadYaml.golden
- File renamed to test/testdata/TestGithubSecondFlakyPullRequestBadYaml.golden to better reflect its purpose.

Activity

No specific activity (comments, reviews, or progress updates) has been recorded for this pull request since its creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

pipelines-as-code · 2026-02-05T06:30:59Z

🔍 PR Lint Feedback

Note: This automated check helps ensure your PR follows our contribution guidelines.

⚠️ Items that need attention:

🎫 Jira reference

Add a Jira reference in the description using one of the following formats:

https://issues.redhat.com/browse/SRVKP-<number>

If no SRVKP ticket exists yet, link a GitHub issue instead (e.g., Fixes #123).
Minor housekeeping PRs without Jira coverage can skip this after confirming with reviewers.

🤖 AI attribution

The following commits lack an explicit AI attribution footer:

e2c0e91 fix: Rename golden file for flaky pull request test

If no AI assistance was used for a commit, you can ignore this warning.
Otherwise add an Assisted-by: or Co-authored-by: footer referencing the AI used.

ℹ️ Next Steps

Review and address the items above
Push new commits to update this PR
This comment will be automatically updated when issues are resolved

🔧 Admin Tools (click to expand)

Automated Issue/Ticket Creation:

/issue-create - Generate a GitHub issue from this PR content using AI
/jira-create - Create a SRVKP Jira ticket from this PR content using AI

⚠️ Important: Always review and edit generated content before finalizing tickets/issues.
The AI-generated content should be used as a starting point and may need adjustments.

These commands are available to maintainers and will post the generated content as PR comments for review.

_{🤖 This feedback was generated automatically by the PR CI system}

gemini-code-assist

Code Review

This pull request renames a golden file to align with its corresponding test function, TestGithubSecondFlakyPullRequestBadYaml. This change correctly updates the test data, likely fixing a test that was failing due to a filename mismatch. The change is straightforward and improves the consistency of the test suite.

Copilot

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T06:31:56Z

test/testdata/TestGithubSecondFlakyPullRequestBadYaml.golden

The PR description claims this is a rename, but the diff only shows a file addition. If this is truly a rename of 'TestGithubPullRequestSecondBadYaml.golden' to 'TestGithubSecondFlakyPullRequestBadYaml.golden', the old file should be deleted in this PR. Additionally, the content differs significantly between the files (1 line vs 6 lines, plain text vs markdown table), which suggests this might be a new file rather than a rename. Please clarify whether this is a rename (and delete the old file) or a new file addition (and update the PR description accordingly).

chmouel · 2026-02-05T06:32:19Z

/test linters

qodo-code-review · 2026-02-05T06:32:25Z

Unsupported PR languages

theakshaypant · 2026-02-05T07:01:58Z

/retest linters

chmouel · 2026-02-05T07:53:41Z

/test linterss

qodo-code-review · 2026-02-05T07:53:48Z

Unsupported PR languages

chmouel · 2026-02-05T07:54:01Z

/retest

chmouel · 2026-02-05T08:43:41Z

/retest

chmouel · 2026-02-05T09:58:05Z

/retest

fix: Rename golden file for flaky pull request test

e2c0e91

Renamed a golden file to better reflect its purpose in testing flaky pull requests. This change improves the clarity and organization of test data.

Copilot AI review requested due to automatic review settings February 5, 2026 06:30

Copilot started reviewing on behalf of chmouel February 5, 2026 06:30 View session

gemini-code-assist bot reviewed Feb 5, 2026

View reviewed changes

pipelines-as-code bot added fix testing labels Feb 5, 2026

Copilot AI reviewed Feb 5, 2026

View reviewed changes

theakshaypant approved these changes Feb 5, 2026

View reviewed changes

chmouel merged commit dfb74fc into tektoncd:main Feb 5, 2026
18 checks passed

chmouel deleted the fix-rename-golden-file-for-flaky-pull-request-test branch February 5, 2026 09:59

Conversation

chmouel commented Feb 5, 2026

Uh oh!

qodo-code-review bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 5, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

pipelines-as-code bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 PR Lint Feedback

⚠️ Items that need attention:

🎫 Jira reference

🤖 AI attribution

ℹ️ Next Steps

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

chmouel commented Feb 5, 2026

Uh oh!

qodo-code-review bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theakshaypant commented Feb 5, 2026

Uh oh!

chmouel commented Feb 5, 2026

Uh oh!

qodo-code-review bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chmouel commented Feb 5, 2026

Uh oh!

chmouel commented Feb 5, 2026

Uh oh!

chmouel commented Feb 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

qodo-code-review bot commented Feb 5, 2026 •

edited

Loading

pipelines-as-code bot commented Feb 5, 2026 •

edited

Loading

qodo-code-review bot commented Feb 5, 2026 •

edited

Loading

qodo-code-review bot commented Feb 5, 2026 •

edited

Loading