fix: use fully qualified urls for images in .tekton#2447
fix: use fully qualified urls for images in .tekton#2447chmouel merged 1 commit intotektoncd:mainfrom
Conversation
adds fully qualified urls for images across .tekton directory in tekton resources. Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
Summary of ChangesHello @zakisk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the image references across various Tekton pipeline definitions by explicitly adding the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🔍 PR Lint Feedback
|
There was a problem hiding this comment.
Code Review
This pull request aims to use fully qualified URLs for container images in the Tekton pipeline definitions, which is a good practice for ensuring that the correct images are pulled. While the changes are in the right direction, I've identified a couple of issues. Firstly, the Go version specified (1.25) for the golang image is not yet released and will cause build failures. I've suggested changing this to a recent stable version. Secondly, several images are using an implicit or explicit latest tag. For reproducible builds, it's crucial to pin images to specific versions. I've provided suggestions for pinning these images as well.
|
|
||
| - name: hugo-gen | ||
| image: golang:1.25 | ||
| image: docker.io/golang:1.25 |
There was a problem hiding this comment.
The Go version 1.25 is used, but this version has not been released yet and is not available on Docker Hub. This will cause the pipeline step to fail when it tries to pull the image. Please use a recent stable version of Go, for example 1.22.
image: docker.io/golang:1.22| value: $(workspaces.source.path) | ||
| - name: unittest | ||
| image: golang:1.25 | ||
| image: docker.io/golang:1.25 |
There was a problem hiding this comment.
The Go version 1.25 is used, but this version has not been released yet and is not available on Docker Hub. This will cause the pipeline step to fail when it tries to pull the image. Please use a recent stable version of Go, for example 1.22.
image: docker.io/golang:1.22| - name: codecov | ||
| # Has everything we need in there and we already fetched it! | ||
| image: golang:1.25 | ||
| image: docker.io/golang:1.25 |
There was a problem hiding this comment.
The Go version 1.25 is used, but this version has not been released yet and is not available on Docker Hub. This will cause the pipeline step to fail when it tries to pull the image. Please use a recent stable version of Go, for example 1.22.
image: docker.io/golang:1.22| ./codecov -C {{revision}} -v | ||
| - name: upload-release | ||
| image: golang:1.25 | ||
| image: docker.io/golang:1.25 |
There was a problem hiding this comment.
The Go version 1.25 is used, but this version has not been released yet and is not available on Docker Hub. This will cause the pipeline step to fail when it tries to pull the image. Please use a recent stable version of Go, for example 1.22.
image: docker.io/golang:1.22| # we get bumped out when usingh the official image with docker.io | ||
| # ratelimit so workaround this. | ||
| image: golang:1.25 | ||
| image: docker.io/golang:1.25 |
There was a problem hiding this comment.
The Go version 1.25 is used, but this version has not been released yet and is not available on Docker Hub. This will cause the pipeline step to fail when it tries to pull the image. Please use a recent stable version of Go, for example 1.22.
image: docker.io/golang:1.22| - name: upload-to-static-server | ||
| # it has curl and we already pulled it | ||
| image: curlimages/curl | ||
| image: docker.io/curlimages/curl |
There was a problem hiding this comment.
The image tag is not specified, which means it will default to latest. Using the latest tag is not recommended for CI/CD pipelines as it can lead to unpredictable behavior when the image is updated. It's best practice to pin the image to a specific version to ensure reproducible builds. A recent version for curlimages/curl is 8.8.0.
image: docker.io/curlimages/curl:8.8.0| ./codecov -P $GITHUB_PULL_REQUEST_ID -C {{revision}} -v | ||
| - name: lint | ||
| image: golangci/golangci-lint:latest | ||
| image: docker.io/golangci/golangci-lint:latest |
There was a problem hiding this comment.
Using the latest tag for Docker images is not recommended for CI/CD pipelines as it can lead to unpredictable behavior when the image is updated. It's best practice to pin the image to a specific version to ensure reproducible builds. For golangci-lint, you could use a specific version like v1.59.1.
image: docker.io/golangci/golangci-lint:v1.59.1| - name: shellcheck | ||
| displayName: "Shell scripts linter" | ||
| image: koalaman/shellcheck-alpine | ||
| image: docker.io/koalaman/shellcheck-alpine |
There was a problem hiding this comment.
The image tag is not specified, which means it will default to latest. Using the latest tag is not recommended for CI/CD pipelines as it can lead to unpredictable behavior. It's best practice to pin the image to a specific version (e.g., stable) to ensure reproducible builds.
image: docker.io/koalaman/shellcheck-alpine:stable| - name: yamllint | ||
| displayName: "YAML Linter" | ||
| image: cytopia/yamllint | ||
| image: docker.io/cytopia/yamllint |
There was a problem hiding this comment.
The image tag is not specified, which means it will default to latest. Using the latest tag is not recommended for CI/CD pipelines as it can lead to unpredictable behavior. It's best practice to pin the image to a specific version (e.g., a version number like 1.35.1) to ensure reproducible builds.
image: docker.io/cytopia/yamllint:1.35.1| - name: markdownlint | ||
| displayName: "Markdown Linter" | ||
| image: thegeeklab/markdownlint-cli | ||
| image: docker.io/thegeeklab/markdownlint-cli |
There was a problem hiding this comment.
The image tag is not specified, which means it will default to latest. Using the latest tag is not recommended for CI/CD pipelines as it can lead to unpredictable behavior. It's best practice to pin the image to a specific version (e.g., a version number like v0.39.0) to ensure reproducible builds.
image: docker.io/thegeeklab/markdownlint-cli:v0.39.0
adds fully qualified urls for images across .tekton directory in tekton resources.
📝 Description of the Change
👨🏻 Linked Jira
🔗 Linked GitHub Issue
Fixes #
🚀 Type of Change
fix:)feat:)feat!:,fix!:)docs:)chore:)refactor:)enhance:)deps:)🧪 Testing Strategy
🤖 AI Assistance
If you have used AI assistance, please provide the following details:
Which LLM was used?
Extent of AI Assistance:
Important
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com
**💡You can use the script
./hack/add-llm-coauthor.shto automatically addthese co-author trailers to your commits.
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.