fix: Show error and fatal logs in snazy output by chmouel · Pull Request #2434 · tektoncd/pipelines-as-code

chmouel · 2026-01-30T07:48:12Z

📝 Description of the Change

👨🏻‍ Linked Jira

🔗 Linked GitHub Issue

Fixes #

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

I have not used any AI assistance for this PR.
I have used AI assistance for this PR.

If you have used AI assistance, please provide the following details:

Which LLM was used?

Extent of AI Assistance:

Documentation and research only
Unit tests or E2E tests only
Code generation (parts of the code)
Full code generation (most of the PR)
PR description and comments
Commit message(s)

Important

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com

**💡You can use the script ./hack/add-llm-coauthor.sh to automatically add
these co-author trailers to your commits.

✅ Submitter Checklist

gemini-code-assist · 2026-01-30T07:48:25Z

Summary of Changes

Hello @chmouel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to improve the debugging experience within the CI pipeline by ensuring that critical log messages, specifically those marked as error or fatal, are prominently displayed in the snazy output. This change will help developers quickly identify and address severe issues during automated test executions.

Highlights

CI Logging Improvement: Enhanced the snazy command in the CI workflow to explicitly filter and display error and fatal log levels, making critical issues more visible during test runs.
Shell Script Syntax Consistency: Applied a minor whitespace correction in the notify_slack function's done <<< construct for improved script consistency.

Ignored Files

Ignored by pattern: .github/workflows/** (1)
- .github/workflows/e2e.yaml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Modified the `snazy` command in the CI script to include the `-f error` and `-f fatal` flags. This ensures that only error and fatal messages instead of showing all log levels are displayed, and mising critical Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

pipelines-as-code · 2026-01-30T07:48:34Z

🔍 PR Lint Feedback

Note: This automated check helps ensure your PR follows our contribution guidelines.

⚠️ Items that need attention:

🎫 Jira reference

Add a Jira reference in the description using one of the following formats:

https://issues.redhat.com/browse/SRVKP-<number>

If no SRVKP ticket exists yet, link a GitHub issue instead (e.g., Fixes #123).
Minor housekeeping PRs without Jira coverage can skip this after confirming with reviewers.

🤖 AI attribution

The following commits lack an explicit AI attribution footer:

3e286df fix: Show error and fatal logs in snazy output
20ea3d1 fix: Improve error log collection naming

If no AI assistance was used for a commit, you can ignore this warning.
Otherwise add an Assisted-by: or Co-authored-by: footer referencing the AI used.

ℹ️ Next Steps

Review and address the items above
Push new commits to update this PR
This comment will be automatically updated when issues are resolved

🔧 Admin Tools (click to expand)

Automated Issue/Ticket Creation:

/issue-create - Generate a GitHub issue from this PR content using AI
/jira-create - Create a SRVKP Jira ticket from this PR content using AI

⚠️ Important: Always review and edit generated content before finalizing tickets/issues.
The AI-generated content should be used as a starting point and may need adjustments.

These commands are available to maintainers and will post the generated content as PR comments for review.

_{🤖 This feedback was generated automatically by the PR CI system}

gemini-code-assist

Code Review

This pull request improves the CI log output by filtering for error and fatal level logs using snazy, which should make it easier to spot problems. The changes are straightforward. I've added one comment regarding a potential issue where the log filtering might be too aggressive and could hide some relevant errors. Otherwise, the changes look good.

gemini-code-assist · 2026-01-30T07:49:55Z

hack/gh-workflow-ci.sh

 output_logs() {
  if command -v "snazy" >/dev/null 2>&1; then
-    snazy --extra-fields --skip-line-regexp="^(Reconcile (succeeded|error)|Updating webhook)" /tmp/logs/pac-pods.log
+    snazy --extra-fields --skip-line-regexp="^(Reconcile (succeeded|error)|Updating webhook)" -f error -f fatal /tmp/logs/pac-pods.log


While adding the log level filters for error and fatal is a great improvement for focusing on important issues, the --skip-line-regexp is configured to filter out lines that start with Reconcile error. This might cause some errors to be unintentionally hidden. To ensure all relevant errors are displayed, consider modifying the regular expression to no longer skip these lines.

Suggested change

snazy --extra-fields --skip-line-regexp="^(Reconcile (succeeded|error)|Updating webhook)" -f error -f fatal /tmp/logs/pac-pods.log

snazy --extra-fields --skip-line-regexp="^(Reconcile succeeded|Updating webhook)" -f error -f fatal /tmp/logs/pac-pods.log

pipelines-as-code bot added ci fix github_actions Pull requests that update GitHub Actions code labels Jan 30, 2026

chmouel force-pushed the only-show-error-fatal-in-snazy branch from 20ea3d1 to 83ec9f3 Compare January 30, 2026 07:49

chmouel merged commit d667b63 into tektoncd:main Jan 30, 2026
4 of 9 checks passed

chmouel deleted the only-show-error-fatal-in-snazy branch January 30, 2026 07:49

gemini-code-assist bot reviewed Jan 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Show error and fatal logs in snazy output#2434

fix: Show error and fatal logs in snazy output#2434
chmouel merged 1 commit intotektoncd:mainfrom
chmouel:only-show-error-fatal-in-snazy

chmouel commented Jan 30, 2026

Uh oh!

gemini-code-assist bot commented Jan 30, 2026

Uh oh!

pipelines-as-code bot commented Jan 30, 2026

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	snazy --extra-fields --skip-line-regexp="^(Reconcile (succeeded\|error)\|Updating webhook)" -f error -f fatal /tmp/logs/pac-pods.log
	snazy --extra-fields --skip-line-regexp="^(Reconcile succeeded\|Updating webhook)" -f error -f fatal /tmp/logs/pac-pods.log

Conversation

chmouel commented Jan 30, 2026

📝 Description of the Change

👨🏻‍ Linked Jira

🔗 Linked GitHub Issue

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

✅ Submitter Checklist

Uh oh!

gemini-code-assist bot commented Jan 30, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

pipelines-as-code bot commented Jan 30, 2026

🔍 PR Lint Feedback

⚠️ Items that need attention:

🎫 Jira reference

🤖 AI attribution

ℹ️ Next Steps

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant