fix(github): support lightweight tags for GitOps commands by zakisk · Pull Request #2407 · tektoncd/pipelines-as-code

zakisk · 2026-01-22T07:51:49Z

When GitOps command /test or /retest is triggered on a lightweight tag, it was causing an error in ParsePayload because GitHub treats annotated and lightweight tags differently:

Annotated tags: ref object type is "tag", requires GetTag API call to resolve the commit SHA
Lightweight tags: ref object type is "commit", the ref already contains the commit SHA directly

The fix uses a switch statement to handle both cases and returns an error for unexpected object types.

Also adds:

Unit tests for lightweight tag and invalid object type scenarios
E2E test coverage for both annotated and lightweight tags
LightweightTag option in test framework

https://issues.redhat.com/browse/SRVKP-10467

📝 Description of the Change

👨🏻‍ Linked Jira

🔗 Linked GitHub Issue

Fixes #

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

I have not used any AI assistance for this PR.
I have used AI assistance for this PR.

If you have used AI assistance, please provide the following details:

Which LLM was used?

Extent of AI Assistance:

Documentation and research only
Unit tests or E2E tests only
Code generation (parts of the code)
Full code generation (most of the PR)
PR description and comments
Commit message(s)

Important

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com

**💡You can use the script ./hack/add-llm-coauthor.sh to automatically add
these co-author trailers to your commits.

✅ Submitter Checklist

gemini-code-assist · 2026-01-22T07:52:09Z

Summary of Changes

Hello @zakisk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a crucial fix for GitOps commands, enabling them to function correctly when invoked on lightweight Git tags. Previously, these commands would encounter errors because the system did not differentiate between annotated and lightweight tags in GitHub's API responses. The changes introduce robust parsing logic to handle both tag types, ensuring that the correct commit SHA is always resolved. This enhancement significantly improves the reliability and usability of GitOps workflows, particularly for projects that utilize lightweight tags.

Highlights

Bug Fix for GitOps Commands on Lightweight Tags: Resolved an issue where GitOps commands like /test or /retest failed when triggered on lightweight tags due to GitHub's differing treatment of annotated and lightweight tags. The system now correctly identifies and processes both types.
Enhanced Tag Parsing Logic: Implemented a switch statement in parse_payload.go to distinguish between 'tag' (annotated) and 'commit' (lightweight) object types, ensuring the correct commit SHA is retrieved for each.
Improved Test Coverage: Added new unit tests to cover scenarios for lightweight tags and invalid object types. E2E tests have also been expanded to include coverage for both annotated and lightweight tags, enhancing overall reliability.
Test Framework Update: Introduced a LightweightTag option in the test framework to facilitate the creation and testing of lightweight tags in E2E environments.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

pipelines-as-code · 2026-01-22T07:52:12Z

🔍 PR Lint Feedback

Note: This automated check helps ensure your PR follows our contribution guidelines.

⚠️ Items that need attention:

🤖 AI attribution

The following commits lack an explicit AI attribution footer:

2274e06 fix(github): support lightweight tags for GitOps commands

If no AI assistance was used for a commit, you can ignore this warning.
Otherwise add an Assisted-by: or Co-authored-by: footer referencing the AI used.

ℹ️ Next Steps

Review and address the items above
Push new commits to update this PR
This comment will be automatically updated when issues are resolved

🔧 Admin Tools (click to expand)

Automated Issue/Ticket Creation:

/issue-create - Generate a GitHub issue from this PR content using AI
/jira-create - Create a SRVKP Jira ticket from this PR content using AI

⚠️ Important: Always review and edit generated content before finalizing tickets/issues.
The AI-generated content should be used as a starting point and may need adjustments.

These commands are available to maintainers and will post the generated content as PR comments for review.

_{🤖 This feedback was generated automatically by the PR CI system}

gemini-code-assist

Code Review

This pull request introduces a fix to support lightweight tags for GitOps commands, which were previously causing errors. The core change in pkg/provider/github/parse_payload.go correctly uses a switch statement to handle both annotated and lightweight tags by inspecting the ref object type. The accompanying unit tests in pkg/provider/github/parse_payload_test.go are well-structured and cover the new logic, including positive and negative cases. The E2E test in test/github_tag_gitops_test.go is also updated to cover both tag types.

My review has identified a critical issue in a test helper function that could cause a panic due to a nil pointer dereference. Additionally, I've noted a reduction in the E2E test's assertions, which weakens its validation. I've provided suggestions to address both points.

test/pkg/github/tag.go

test/github_tag_gitops_test.go

zakisk · 2026-01-22T09:16:38Z

/gemini-review

chmouel · 2026-01-26T16:57:08Z

failure is accurate, can reproduce locally

When GitOps command `/test` or `/retest` is triggered on a lightweight tag, it was causing an error in ParsePayload because GitHub treats annotated and lightweight tags differently: - Annotated tags: ref object type is "tag", requires GetTag API call to resolve the commit SHA - Lightweight tags: ref object type is "commit", the ref already contains the commit SHA directly The fix uses a switch statement to handle both cases and returns an error for unexpected object types. Also adds: - Unit tests for lightweight tag and invalid object type scenarios - E2E test coverage for both annotated and lightweight tags - LightweightTag option in test framework https://issues.redhat.com/browse/SRVKP-10467 Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>

zakisk requested a review from chmouel January 22, 2026 07:51

pipelines-as-code bot added e2e fix github labels Jan 22, 2026

gemini-code-assist bot reviewed Jan 22, 2026

View reviewed changes

test/pkg/github/tag.go Outdated Show resolved Hide resolved

test/github_tag_gitops_test.go Show resolved Hide resolved

zakisk force-pushed the SRVKP-10467-fix-gitops-comment-on-lightweight-tag branch from d94bc40 to 3461ff0 Compare January 22, 2026 09:15

zakisk force-pushed the SRVKP-10467-fix-gitops-comment-on-lightweight-tag branch from 24aad61 to 8227a63 Compare February 11, 2026 06:39

zakisk force-pushed the SRVKP-10467-fix-gitops-comment-on-lightweight-tag branch from 8227a63 to 2274e06 Compare February 11, 2026 10:46

chmouel merged commit f7d229d into tektoncd:main Feb 11, 2026
13 checks passed

zakisk deleted the SRVKP-10467-fix-gitops-comment-on-lightweight-tag branch February 11, 2026 11:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(github): support lightweight tags for GitOps commands#2407

fix(github): support lightweight tags for GitOps commands#2407
chmouel merged 1 commit intotektoncd:mainfrom
zakisk:SRVKP-10467-fix-gitops-comment-on-lightweight-tag

zakisk commented Jan 22, 2026

Uh oh!

gemini-code-assist bot commented Jan 22, 2026

Uh oh!

pipelines-as-code bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

zakisk commented Jan 22, 2026

Uh oh!

chmouel commented Jan 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

zakisk commented Jan 22, 2026

📝 Description of the Change

👨🏻‍ Linked Jira

🔗 Linked GitHub Issue

🚀 Type of Change

🧪 Testing Strategy

🤖 AI Assistance

✅ Submitter Checklist

Uh oh!

gemini-code-assist bot commented Jan 22, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

pipelines-as-code bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 PR Lint Feedback

⚠️ Items that need attention:

🤖 AI attribution

ℹ️ Next Steps

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

zakisk commented Jan 22, 2026

Uh oh!

chmouel commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pipelines-as-code bot commented Jan 22, 2026 •

edited

Loading

chmouel commented Jan 26, 2026 •

edited

Loading