What people are seeing

After the recent watcher secret-handling changes, two confusing things started happening:

1. The watcher logs an error saying secret creation failed, even when it actually worked.
2. Links to the PipelineRun in the cluster console sometimes point to https://openshift.url.is.not.configured/... instead of the real OpenShift console.

Why this is a problem

This makes it look like the watcher is failing when it is not, which can send people looking in the wrong place during debugging.

The broken console link also makes it harder to inspect failed or running PipelineRuns from GitHub checks, because the link goes to a placeholder URL instead of the cluster console.

User impact

• Logs are noisy and misleading
• Debugging watcher behavior is harder than it should be
• GitHub check links to PipelineRuns may be unusable

Likely regression window

This seems to have shown up after the large merge that moved secret creation into the reconciler.

Notes

Observed example from watcher logs:

• failed to create secret for pipelineRun pipelines-as-code-ci/linters-jx4d8: <nil>

Observed broken link pattern:

• https://openshift.url.is.not.configured/k8s/ns/.../tekton.dev~v1~PipelineRun/...

The issue appears to be:

• a false error log emitted even when secret creation succeeds
• console URL fallback replacing the current console UI with an empty OpenShift console object when route discovery fails