Skip to content

Failing unit test in webhook validation after dependency bump (grpc 1.79.3) #2592

@chmouel

Description

@chmouel

The Pipelines as Code CI is failing on main after the recent dependency update (google.golang.org/grpc from 1.78.0 to 1.79.3). The failure occurs in the unit test task, specifically within webhook validation tests.

Failure details
PipelineRun: push-generate-coverage-releaseyaml-647q9
Namespace: pipelines-as-code-ci

FAIL github.com/openshift-pipelines/pipelines-as-code/pkg/webhook 1.151s
make: *** [Makefile:70: test-unit] Error 1

Error location

validation_test.go:195
assertion failed: true (res.Allowed bool) != false (tt.allowed bool)

Observed behavior
A test expectation in validation_test.go no longer matches the actual result. The test expects Allowed=false, but the code returns Allowed=true.

Expected behavior
Unit tests should pass consistently on main. The validation logic should either:

  • remain unchanged and tests should reflect correct expectations, or
  • tests should be updated if the behavior change is intentional.

Context
This started after:

chore(deps): bump google.golang.org/grpc from 1.78.0 to 1.79.3

Potential causes

  • Behavioral change introduced by grpc update
  • Side effect in webhook validation logic (possibly admission handling or context propagation)
  • Test relying on assumptions affected by dependency behavior

Suggested actions

  • Identify what changed in validation logic or grpc interaction
  • Confirm whether the new behavior is correct
  • Update test expectations if intentional, otherwise fix regression

Additional info
CI link indicates failure in:
Pipelines as Code Dogfooding CI / push-generate-coverage-releaseyaml

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions