test: remove nightly tests completely

zakisk · zakisk · commit dbb7b35eb32a · 2026-03-10T12:48:16.000+05:30
this commit removes nightly tests completely
because we don't need nightly tests anymore.
nighlty tests were added to avoid rate limiting
issue but as we moved to GHE we don't have rate
limit issue anymore.

Signed-off-by: Zaki Shaikh &lt;zashaikh@redhat.com&gt;
diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml
@@ -505,26 +505,6 @@ jobs:
         run: |
           ./hack/gh-workflow-ci.sh run_e2e_tests
 
-      - name: Run E2E Tests on nightly
-        # This step still runs specifically for schedule or workflow_dispatch
-        if: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }}
-        env:
-          NIGHTLY_E2E_TEST: "true"
-          TEST_PROVIDER: ${{ matrix.provider }}
-          TEST_BITBUCKET_CLOUD_TOKEN: ${{ secrets.BITBUCKET_CLOUD_TOKEN }}
-          TEST_EL_WEBHOOK_SECRET: ${{ secrets.WEBHOOK_SECRET }}
-          TEST_GITHUB_REPO_INSTALLATION_ID: ${{ vars.INSTALLATION_ID }}
-          TEST_GITHUB_TOKEN: ${{ secrets.GH_APPS_TOKEN }}
-          TEST_GITHUB_SECOND_TOKEN: ${{ secrets.TEST_GITHUB_SECOND_TOKEN }}
-          TEST_GITHUB_SECOND_WEBHOOK_TOKEN: ${{ secrets.TEST_GITHUB_SECOND_WEBHOOK_TOKEN }}
-          TEST_GITLAB_TOKEN: ${{ secrets.GITLAB_TOKEN }}
-          TEST_BITBUCKET_SERVER_TOKEN: ${{ secrets.BITBUCKET_SERVER_TOKEN }}
-          TEST_BITBUCKET_SERVER_API_URL: ${{ secrets.BITBUCKET_SERVER_API_URL }}
-          TEST_BITBUCKET_SERVER_WEBHOOK_SECRET: ${{ secrets.BITBUCKET_SERVER_WEBHOOK_SECRET }}
-          TEST_GITHUB_SECOND_APPLICATION_ID: ${{ vars.TEST_GITHUB_SECOND_APPLICATION_ID }}
-        run: |
-          ./hack/gh-workflow-ci.sh run_e2e_tests
-
       - name: Collect logs
         if: ${{ always() }}
         env:
diff --git a/test/README.md b/test/README.md
@@ -152,28 +152,6 @@ To clean up stale test projects (older than 7 days) left from previous runs:
 
 If you need to update the golden files in the end-to-end test, add the `-update` flag to the [go test](https://pkg.go.dev/cmd/go#hdr-Test_packages) command to refresh those files. First, run it if you expect the test output to change (or for a new test), then run it again without the flag to ensure everything is correct.
 
-## Running nightly tests
-
-Some tests are set as nightly which mean not run on every PR, because exposing rate limitation often.
-We run those as nightly via github action on kind.
-
-You can use `make test-e2e-nightly` if you want to run those manually as long
-as you have all the env variables set.
-
-If you are writing a test targeting a nightly test you need to check for the env variable:
-
-```go
-    if os.Getenv("NIGHTLY_E2E_TEST") != "true" {
-        t.Skip("Skipping test since only enabled for nightly")
-    }
-```
-
-and maybe add to the test-e2e-nightly Makefile target to the -run argument :
-
-```bash
--run '(TestGithub|TestOtherPrefixOfTest)'
-```
-
 ## Continuous Integration (CI) with GitHub Actions
 
 Our E2E tests are automatically run as part of our CI pipeline using GitHub Actions. This section explains how the CI process works, the components involved, and how to troubleshoot or extend it.
@@ -363,7 +341,6 @@ To add new provider tests:
 1. Create test files following the existing patterns
 2. Ensure proper naming convention to match the test category filters
 3. Update environment variables if needed
-4. For nightly-only tests, include the check for `NIGHTLY_E2E_TEST`
 
 For infrastructure changes:
 
diff --git a/test/github_pullrequest_oktotest_test.go b/test/github_pullrequest_oktotest_test.go
@@ -21,9 +21,6 @@ import (
 )
 
 func TestGithubGHEPullRequestOkToTest(t *testing.T) {
-	if os.Getenv("NIGHTLY_E2E_TEST") != "true" {
-		t.Skip("Skipping test since only enabled for nightly")
-	}
 	ctx := context.TODO()
 	g := &tgithub.PRTest{
 		Label:     "Github OkToTest comment",
diff --git a/test/github_pullrequest_retest_test.go b/test/github_pullrequest_retest_test.go
@@ -21,9 +21,6 @@ import (
 // TestGithubGHEPullRequestGitopsCommentRetest will test the retest
 // functionality of a GitHub pull request.
 func TestGithubGHEPullRequestGitopsCommentRetest(t *testing.T) {
-	if os.Getenv("NIGHTLY_E2E_TEST") != "true" {
-		t.Skip("Skipping test since only enabled for nightly")
-	}
 	ctx := context.Background()
 	g := &tgithub.PRTest{
 		Label:         "Github retest comment",
diff --git a/test/github_pullrequest_test.go b/test/github_pullrequest_test.go
@@ -55,9 +55,6 @@ func TestGithubGHEPullRequest(t *testing.T) {
 }
 
 func TestGithubGHEPullRequestMultiples(t *testing.T) {
-	if os.Getenv("NIGHTLY_E2E_TEST") != "true" {
-		t.Skip("Skipping test since only enabled for nightly")
-	}
 	ctx := context.Background()
 	g := &tgithub.PRTest{
 		Label:     "Github multiple PullRequest",
@@ -69,9 +66,6 @@ func TestGithubGHEPullRequestMultiples(t *testing.T) {
 }
 
 func TestGithubGHEPullRequestMatchOnCEL(t *testing.T) {
-	if os.Getenv("NIGHTLY_E2E_TEST") != "true" {
-		t.Skip("Skipping test since only enabled for nightly")
-	}
 	ctx := context.Background()
 	g := &tgithub.PRTest{
 		Label:     "Github CEL Match",
diff --git a/test/github_pullrequest_test_comment_test.go b/test/github_pullrequest_test_comment_test.go
@@ -18,9 +18,6 @@ import (
 )
 
 func TestGithubGHEPullRequestTest(t *testing.T) {
-	if os.Getenv("NIGHTLY_E2E_TEST") != "true" {
-		t.Skip("Skipping test since only enabled for nightly")
-	}
 	ctx := context.TODO()
 	g := &tgithub.PRTest{
 		Label:     "Github test implicit comment",
diff --git a/test/github_scope_token_to_list_of_private_public_repos_test.go b/test/github_scope_token_to_list_of_private_public_repos_test.go
@@ -29,9 +29,6 @@ import (
 
 func TestGithubPullRequestScopeTokenToListOfRepos(t *testing.T) {
 	t.Skip("Skipping test changing the global config map for now")
-	if os.Getenv("NIGHTLY_E2E_TEST") != "true" {
-		t.Skip("Skipping test since only enabled for nightly")
-	}
 
 	var remoteTaskURL, remoteTaskName string
 	if os.Getenv("TEST_GITHUB_PRIVATE_TASK_URL") != "" {
@@ -55,9 +52,6 @@ func TestGithubPullRequestScopeTokenToListOfRepos(t *testing.T) {
 
 func TestGithubPullRequestScopeTokenToListOfReposByGlobalConfiguration(t *testing.T) {
 	t.Skip("Skipping test changing the global config map for now")
-	if os.Getenv("NIGHTLY_E2E_TEST") != "true" {
-		t.Skip("Skipping test since only enabled for nightly")
-	}
 
 	var remoteTaskURL, remoteTaskName string
 	if os.Getenv("TEST_GITHUB_PRIVATE_TASK_URL") != "" {

Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,6 @@ import (`
`21`	`21`	`)`
`22`	`22`
`23`	`23`	`func TestGithubGHEPullRequestOkToTest(t *testing.T) {`
`24`		`- if os.Getenv("NIGHTLY_E2E_TEST") != "true" {`
`25`		`- t.Skip("Skipping test since only enabled for nightly")`
`26`		`- }`
`27`	`24`	`ctx := context.TODO()`
`28`	`25`	`g := &tgithub.PRTest{`
`29`	`26`	`Label: "Github OkToTest comment",`
Original file line number	Diff line number	Diff line change
`@@ -18,9 +18,6 @@ import (`
`18`	`18`	`)`
`19`	`19`
`20`	`20`	`func TestGithubGHEPullRequestTest(t *testing.T) {`
`21`		`- if os.Getenv("NIGHTLY_E2E_TEST") != "true" {`
`22`		`- t.Skip("Skipping test since only enabled for nightly")`
`23`		`- }`
`24`	`21`	`ctx := context.TODO()`
`25`	`22`	`g := &tgithub.PRTest{`
`26`	`23`	`Label: "Github test implicit comment",`