refactor: Rename github pull request test function

chmouel · theakshaypant · commit 9c30b5dea3c8 · 2026-01-23T11:57:00.000+05:30
Renamed `TestGithubPullRequestSecondController` to
`TestGithubSecondPullRequest` so the e2e runners categorize it as
running on second controllers.
diff --git a/hack/gh-workflow-ci.sh b/hack/gh-workflow-ci.sh
@@ -78,31 +78,32 @@ get_tests() {
   all_tests=$(grep -hioP '^func[[:space:]]+Test[[:alnum:]_]+' "${testfiles[@]}" | sed -E 's/^func[[:space:]]+//')
 
   case "${target}" in
-    concurrency)
-      printf '%s\n' "${all_tests}" | grep -iP 'Concurrency'
-      ;;
-    github)
-      printf '%s\n' "${all_tests}" | grep -iP 'Github' | grep -ivP 'Concurrency|GithubSecond|SecondController'
-      ;;
-    github_second_controller)
-      printf '%s\n' "${all_tests}" | grep -iP 'GithubSecond|SecondController' | grep -ivP 'Concurrency'
-      ;;
-    gitlab_bitbucket)
-      printf '%s\n' "${all_tests}" | grep -iP 'Gitlab|Bitbucket' | grep -ivP 'Concurrency'
-      ;;
-    gitea_others)
-      printf '%s\n' "${all_tests}" | grep -ivP 'Github|Gitlab|Bitbucket|Concurrency'
-      ;;
-    *)
-      echo "Invalid target: ${target}"
-      echo "supported targets: github, github_second_controller, gitlab_bitbucket, gitea_others, concurrency"
-      ;;
+  concurrency)
+    printf '%s\n' "${all_tests}" | grep -iP 'Concurrency'
+    ;;
+  github)
+    printf '%s\n' "${all_tests}" | grep -iP 'Github' | grep -ivP 'Concurrency|GithubSecond'
+    ;;
+  github_second_controller)
+    printf '%s\n' "${all_tests}" | grep -iP 'GithubSecond' | grep -ivP 'Concurrency'
+    ;;
+  gitlab_bitbucket)
+    printf '%s\n' "${all_tests}" | grep -iP 'Gitlab|Bitbucket' | grep -ivP 'Concurrency'
+    ;;
+  gitea_others)
+    printf '%s\n' "${all_tests}" | grep -ivP 'Github|Gitlab|Bitbucket|Concurrency'
+    ;;
+  *)
+    echo "Invalid target: ${target}"
+    echo "supported targets: github, github_second_controller, gitlab_bitbucket, gitea_others, concurrency"
+    ;;
   esac
 }
 
 run_e2e_tests() {
   set +x
   target="${TEST_PROVIDER}"
+  export PAC_E2E_KEEP_NS=true
 
   mapfile -t tests < <(get_tests "${target}")
   echo "About to run ${#tests[@]} tests: ${tests[*]}"
diff --git a/test/github_pullrequest_test.go b/test/github_pullrequest_test.go
@@ -43,7 +43,7 @@ func TestGithubPullRequest(t *testing.T) {
 	defer g.TearDown(ctx, t)
 }
 
-func TestGithubPullRequestSecondController(t *testing.T) {
+func TestGithubSecondPullRequest(t *testing.T) {
 	ctx := context.Background()
 	g := &tgithub.PRTest{
 		Label:            "Github Rerequest",
diff --git a/test/pkg/repository/teardown.go b/test/pkg/repository/teardown.go
@@ -2,6 +2,7 @@ package repository
 
 import (
 	"context"
+	"os"
 	"testing"
 
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/params"
@@ -13,7 +14,9 @@ func NSTearDown(ctx context.Context, t *testing.T, runcnx *params.Run, targetNS
 	runcnx.Clients.Log.Infof("Deleting Repository in %s", targetNS)
 	err := runcnx.Clients.PipelineAsCode.PipelinesascodeV1alpha1().Repositories(targetNS).DeleteCollection(ctx, metav1.DeleteOptions{}, metav1.ListOptions{})
 	assert.NilError(t, err)
-	runcnx.Clients.Log.Infof("Deleting NS %s", targetNS)
-	err = runcnx.Clients.Kube.CoreV1().Namespaces().Delete(ctx, targetNS, metav1.DeleteOptions{})
-	assert.NilError(t, err)
+	if os.Getenv("PAC_E2E_KEEP_NS") != "true" {
+		runcnx.Clients.Log.Infof("Deleting NS %s", targetNS)
+		err = runcnx.Clients.Kube.CoreV1().Namespaces().Delete(ctx, targetNS, metav1.DeleteOptions{})
+		assert.NilError(t, err)
+	}
 }

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ func TestGithubPullRequest(t *testing.T) {`
`43`	`43`	`defer g.TearDown(ctx, t)`
`44`	`44`	`}`
`45`	`45`
`46`		`-func TestGithubPullRequestSecondController(t *testing.T) {`
	`46`	`+func TestGithubSecondPullRequest(t *testing.T) {`
`47`	`47`	`ctx := context.Background()`
`48`	`48`	`g := &tgithub.PRTest{`
`49`	`49`	`Label: "Github Rerequest",`