Skip to content

Commit 5a17019

Browse files
committed
fix: enforce TEST_GITHUB_SECOND_WEBHOOK_SECRET existence
this checks for TEST_GITHUB_SECOND_WEBHOOK_SECRET var in e2e tests Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
1 parent dbb7b35 commit 5a17019

4 files changed

Lines changed: 2 additions & 3 deletions

File tree

test/github_pullrequest_retest_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ package test
55
import (
66
"context"
77
"fmt"
8-
"os"
98
"strings"
109
"testing"
1110

test/github_pullrequest_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ package test
55
import (
66
"context"
77
"fmt"
8-
"os"
98
"regexp"
109
"strings"
1110
"testing"

test/github_pullrequest_test_comment_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ package test
55
import (
66
"context"
77
"fmt"
8-
"os"
98
"regexp"
109
"testing"
1110

test/pkg/github/setup.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ func setupEnvVars(onGHE, viaDirectWebhook bool) (*envConfig, error) {
8585
"TEST_GITHUB_SECOND_API_URL",
8686
"TEST_GITHUB_SECOND_EL_URL",
8787
"TEST_GITHUB_SECOND_WEBHOOK_TOKEN",
88+
"TEST_GITHUB_SECOND_WEBHOOK_SECRET",
8889
)
8990
if err := setup.RequireEnvs(requiredEnvs...); err != nil {
9091
return nil, err
@@ -104,6 +105,7 @@ func setupEnvVars(onGHE, viaDirectWebhook bool) (*envConfig, error) {
104105
"TEST_GITHUB_SECOND_TOKEN",
105106
"TEST_GITHUB_SECOND_REPO_OWNER_GITHUBAPP",
106107
"TEST_GITHUB_SECOND_REPO_INSTALLATION_ID",
108+
"TEST_GITHUB_SECOND_WEBHOOK_SECRET",
107109
)
108110
if err := setup.RequireEnvs(requiredEnvs...); err != nil {
109111
return nil, err

0 commit comments

Comments
 (0)