Skip to content

Add ZSH completion on delete commands #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tekton-robot merged 1 commit into from
Sep 3, 2019
Merged

Add ZSH completion on delete commands #266

tekton-robot merged 1 commit into from
Sep 3, 2019

Conversation

@chmouel
Copy link
Member

@chmouel chmouel commented Sep 3, 2019

Closes #264

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 3, 2019
@tekton-robot
Copy link
Contributor

tekton-robot commented Sep 3, 2019

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/clustertask/delete.go 93.3% 93.5% 0.2
pkg/cmd/pipeline/delete.go 90.7% 90.9% 0.2
pkg/cmd/pipelineresource/delete.go 93.3% 93.5% 0.2
pkg/cmd/pipelinerun/delete.go 93.3% 93.5% 0.2
pkg/cmd/task/delete.go 90.7% 90.9% 0.2
pkg/cmd/taskrun/delete.go 93.3% 93.5% 0.2

@chmouel
Add ZSH completion on delete commands
62c6272 
Closes tektoncd#264

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel chmouel force-pushed the issue-264-zsh-completion-is-not branch from a3f4fcf to 62c6272 Compare September 3, 2019 08:53
@tekton-robot
Copy link
Contributor

tekton-robot commented Sep 3, 2019

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/clustertask/delete.go 93.3% 93.5% 0.2
pkg/cmd/pipeline/delete.go 90.7% 90.9% 0.2
pkg/cmd/pipelineresource/delete.go 93.3% 93.5% 0.2
pkg/cmd/pipelinerun/delete.go 93.3% 93.5% 0.2
pkg/cmd/task/delete.go 90.7% 90.9% 0.2
pkg/cmd/taskrun/delete.go 93.3% 93.5% 0.2

@vdemeester
Copy link
Member

vdemeester commented Sep 3, 2019

/test pull-tekton-cli-build-tests

vdemeester
vdemeester approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2019
@tekton-robot
Copy link
Contributor

tekton-robot commented Sep 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2019
@tekton-robot tekton-robot merged commit 2ee8747 into tektoncd:master Sep 3, 2019
@chmouel chmouel deleted the issue-264-zsh-completion-is-not branch September 4, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@hrishin hrishin Awaiting requested review from hrishin

Assignees

@vdemeester vdemeester

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

zsh completion is not offerring objects on delete commands

4 participants

@chmouel @tekton-robot @vdemeester @googlebot