Remove old taskrun finalizer #1394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 40b47b9 introduced new compliant finalizer name. One edge case missed was that during upgrade, existing taskruns with the old finalizer name will remain on the cluster until the old finalizer name is removed. This is a temporary fix, until we can consider all deployments has switched to the new version/finalizer name.
6 tasks
|
The following is the coverage report on the affected files.
|
lcarva
reviewed
Jul 1, 2025
lcarva
approved these changes
Jul 7, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcarva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 40b47b9 introduced new compliant finalizer name. One edge case missed was that during upgrade, existing taskruns with the old finalizer name will remain on the cluster until the old finalizer name is removed. This is a temporary fix, until we can consider all deployments has switched to the new version/finalizer name.
/kind bug
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes