Skip to content

feat: implement aqua/mise distribution support#45

Merged
technicalpickles merged 6 commits intomainfrom
aqua-distribution
Sep 10, 2025
Merged

feat: implement aqua/mise distribution support#45
technicalpickles merged 6 commits intomainfrom
aqua-distribution

Conversation

@technicalpickles
Copy link
Copy Markdown
Owner

Overview

This PR implements aqua/mise distribution support for envsense, allowing users to install via `mise install aqua:envsense`.

Changes

Phase 1: Release Signing ✅

  • ✅ Modified `.github/workflows/release.yml` to include cosign keyless signing
  • ✅ Added `id-token: write` permission for GitHub Actions OIDC
  • ✅ Created `scripts/validate-signing.sh` for signature verification
  • ✅ Bumped version to 0.3.1 to test signing process

Phase 2: Aqua Configuration ✅

  • ✅ Created `aqua-registry-entry.yaml` with complete configuration
  • ✅ Added support for all platforms (Linux x64, macOS Universal)
  • ✅ Configured cosign signature verification in aqua config
  • ✅ Created `scripts/test-aqua-local.sh` for local testing

Documentation ✅

  • ✅ Created comprehensive `docs/testing-aqua-installation.md`
  • ✅ Added testing procedures and troubleshooting guide
  • ✅ Included cross-platform testing matrix

Testing Plan

  1. CI Tests: All existing tests pass ✅
  2. Release Signing: This PR will test the new signing process
  3. Signature Validation: Run `./scripts/validate-signing.sh` after release
  4. Local Aqua Testing: Run `./scripts/test-aqua-local.sh` (will work after signed release)

Next Steps (Post-Merge)

  1. Validate 0.3.1 release has `.sig` files
  2. Test aqua configuration with signed release
  3. Submit to aqua-registry upstream
  4. Update README with installation instructions

Validation

  • All tests pass
  • Version bumped consistently across workspace
  • Scripts are executable and functional
  • Documentation is comprehensive
  • Release signing works (will be validated by this PR)

This implements the aqua distribution plan outlined in `docs/planning/aqua-distribution/implementation-plan.md`.

- Add cosign keyless signing to GitHub Actions release workflow
- Bump version to 0.3.1 for testing signed releases
- Create validation script for verifying release signatures
- Add aqua registry configuration for upstream submission
- Create comprehensive testing documentation
- Add local testing script for aqua configuration

This implements Phase 1 and Phase 2 of the aqua distribution plan,
enabling envsense to be distributed via 'mise install aqua:envsense'.
Copilot AI review requested due to automatic review settings September 10, 2025 15:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements aqua/mise distribution support for envsense, allowing users to install via mise install aqua:envsense. The implementation includes release signing with cosign keyless signatures, aqua registry configuration, comprehensive testing scripts, and documentation. This enables secure, cryptographically-verified installation of envsense through the popular mise/aqua package manager ecosystem.

  • Implements cosign keyless signing in GitHub Actions release workflow for cryptographic verification
  • Creates aqua registry configuration with signature verification support
  • Adds validation and testing scripts for the signing and installation process

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/release.yml Adds cosign keyless signing and OIDC permissions to release workflow
scripts/validate-signing.sh Script to validate release signatures are working correctly
scripts/test-aqua-local.sh Script to test aqua configuration with local registry setup
aqua-registry-entry.yaml Aqua registry configuration defining package metadata and signing verification
docs/testing-aqua-installation.md Comprehensive testing documentation for aqua installation
docs/planning/aqua-distribution/ Planning documents outlining implementation strategy
Cargo.toml, envsense-macros/Cargo.toml, envsense-macros/envsense-macros-impl/Cargo.toml Version bumps to 0.3.1 for testing signing process

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

packages:
- name: envsense
registry: test-local
version: v0.3.0 # Use current version from Cargo.toml
Copy link

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded version v0.3.0 in the comment doesn't match the actual version being used (0.3.1 per the version bump). This should be updated to reflect the current version or made dynamic to avoid future inconsistencies.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@technicalpickles technicalpickles merged commit 81815d9 into main Sep 10, 2025
9 checks passed
@technicalpickles technicalpickles deleted the aqua-distribution branch September 10, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants