Update typemap for Duckdb v0.10.1#28
Merged
cnuernber merged 3 commits intotechascent:mainfrom Apr 6, 2024
Merged
Conversation
fix: update typemaps to duckdb v0.10.1 This commit reverts the breaking type mapping definitions that the duckdb team introduced in `v0.10.0` and switches them to how they do them in `v0.10.1` / `v0.9.2`. ie. They realized that they broke all C-based APIs and undid the UHUGEINT insertion. In here is also a bit of a refactor that tries to get some of the DRYness of the `define-long-enums` while also mimicking the new style of the C api (where they use explicit mappings on enums). See [this pull request](duckdb/duckdb#10649) for details. I think this strikes a nice balance between clarity and DRYness. Lastly we now only error on version `v0.10.0` since this should restore compatibility with `v0.9.2`. I confirmed that the test suite passes when using duckdb `v0.9.2` via nix flakes.
Add duckdb to the devShell in the nix flake so that we can easily test different versions of Duckdb
Get the latest version of duckdb
82fc1cd to
217c4e2
Compare
Contributor
|
Glad to see this, adding to the middle of the enum struck me as a bit of a noob mistake. Definitely appreciate your efforts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reverts the breaking type mapping definitions that the duckdb team introduced in
v0.10.0and switches them to how they do them inv0.10.1/v0.9.2. ie. They realized that they broke all C-based APIs and undid the UHUGEINT insertion.In here is also a bit of a refactor that tries to get some of the DRYness of the
define-long-enumswhile also mimicking the new style of the C api (where they use explicit mappings on enums). See this pull request for details. I think this strikes a nice balance between clarity and DRYness.Lastly we now only error on version
v0.10.0since this should restore compatibility withv0.9.2. I confirmed that the test suite passes when using duckdbv0.9.2via nix flakes.