vscode: Instead of expecting certain remote edits, expect their result#390
Merged
vscode: Instead of expecting certain remote edits, expect their result#390
Conversation
When a remote edit replaces "x" with "XxX", VS Code will see a TextDocumentChangeEvent that inserts two X's around the x. Because of that, it's not possible to directly compare the edits. Here's a proposed solution: Store the expected resulting content of the document after the remote edit, then see if a local edit results in that content.
Contributor
Author
|
I still managed to have some inconsistencies by running this script in Neovim: And then inserting/deleting x'es in the second line in VS Code. This will sometimes result in errors like this:
|
zormit
approved these changes
Sep 25, 2025
Contributor
Author
|
Even though this PR doesn't solve all VS Code consistency issues, we decided that it's an improvement, and we can iterate more on it in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a remote edit replaces "x" with "XxX", VS Code will see a
TextDocumentChangeEvent that inserts two X's around the x. Because of
that, it's not possible to directly compare the edits.
Here's a proposed solution: Store the expected resulting content of the
document after the remote edit, then see if a local edit results in that
content.