Fix tailing logs stops working after sometimes#4
Merged
tdevelioglu merged 1 commit intotdevelioglu:masterfrom May 20, 2020
Merged
Fix tailing logs stops working after sometimes#4tdevelioglu merged 1 commit intotdevelioglu:masterfrom
tdevelioglu merged 1 commit intotdevelioglu:masterfrom
Conversation
Author
|
I found out that this issue was fixed in hpcloud/tail#99, but the hpcloud/tail version we're using (v1.0.0 - the latest release) doesn't have that commit yet |
Author
|
Updated the PR with updating |
Owner
|
Hi Anh, lgtm. Could you also mention in the commit message why the change to fsnotify was made ? |
Mainly to include this change: hpcloud/tail#99 I also ran `go mod tidy` to update indirect dependency (fsnotify)
Author
|
just updated as requested. fsnotify was changed because I ran |
Owner
|
Thanks! |
73 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prometheus-nginx-log-exporter stopped tailing logs on many of my servers
after sometimes and needed a manual restart to start working again.
I couldn't able to reproduce it, but as suggested here,
switching from inotify (default) to poll might help to fix the issue.
Also in a similar nginx log exporter, they're using
Poll: trueas well.