Implementation of Ratcliff-Obershelp algorithm#55
Merged
Conversation
Added Ratcliff-Obershelp implementation, ported from .Net code by Ligi (https://github.com/dxpux)
Clean up the code and have it pass the check style.
Test unit for Ratcliff-Obershelp algorithm
Added test data from various sources.
Fixed diamond operator to comply with Java 1.6
Cosmetic edit
Contributor
|
Style-wise looks good to me! |
Owner
|
Hi! I just created release 2.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've added unit test, and made few cosmetic changes and passed the build, style-check and coverall check as well.
I've edited the README.md as well, but am not an expert to the algorithm and the Big O notation, so perhaps further edit is required.
Thank you