Many thanks for your help. Approved to keep running tests and CICDs.

It seems we have one failed CICD, would you please check and fix it? It can be from recent days not yours but it can be good if you can fix it as well.

https://github.com/tcort/markdown-link-check/actions/runs/17825862624/job/50680043041?pr=511

Many thanks.

@BaseMax

The CI failure is in Node.js 18 which reached end-of-life on Apr 30, 2025 already.

I would suggest to update the tested Node.js versions in ci.yml in a separate PR

20, 22 & 24 are the currently supported release lines of Node.js

No problem at all, a bit unsure why it failed (Node 18 also passed on windows and macos) but looks like it might be related to my change, or perhaps can you rerun that work flow to see if it's intermittent?

1. markdown-link-check
   should check the links in sample.md:
   Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/markdown-link-check/markdown-link-check/test/markdown-link-check.test.js)
   at listOnTimeout (node:internal/timers:569:17)
   at process.processTimers (node:internal/timers:512:7)

@BaseMax

• I've submitted PR ci: remove Node.js 18 and 23, add 24 to test workflow #512 to follow up on the suggestion I made to update the set of Node.js versions tested. The PR moves the "Test library" workflow to test each of the currently supported versions of Node.js (20, 22 & 24).

@BaseMax

I suggest also re-running the failed test, as it is a timeout error, and this just may be flake and it could pass if you try again.

If it does not pass, then I would suggest reviewing and merging the CI update to the Node.js versions, as I don't think that it is worthwhile to spend time to fix an issue on Node.js 18 that is already past its end-of-life milestone.

Many thanks. I updated CI, lets double check again.

no problem ;)