test(integration): Add simple integration test#416
Merged
WillGibson merged 2 commits intomasterfrom Apr 7, 2025
Merged
Conversation
WillGibson
commented
Feb 27, 2025
.github/workflows/ci.yml
Outdated
| run: npm test | ||
|
|
||
| - name: Integration test | ||
| run: ./markdown-link-check test/alive-links-only.md |
Collaborator
Author
There was a problem hiding this comment.
Maybe I should add examples using each the command flags.
Also noticed that the command reference in the readme does not match what we get from --help.
Collaborator
Author
There was a problem hiding this comment.
I've been imagining this at the gym. Will add some more checks later.
Collaborator
Author
There was a problem hiding this comment.
I think this addition will catch the worst, it really won't work clangers, but I think it will be worth reviewing again when unit test coverage is fuller.
smainil
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From this suggestion: #413 (comment)