chore(deps): Remove unused dependencies#415
Merged
Conversation
smainil
reviewed
Feb 27, 2025
package.json
Outdated
| "eslint": "^9.14.0", | ||
| "expect.js": "^0.3.1", | ||
| "express": "^4.21.1", | ||
| "globals": "^15.12.0", |
Collaborator
There was a problem hiding this comment.
used in
markdown-link-check/eslint.config.mjs
Line 4 in f6bc588
Collaborator
Author
There was a problem hiding this comment.
Yes, that comes with eslint/eslintrc.
Contributor
There was a problem hiding this comment.
markdown-link-check/eslint.config.mjs
Line 2 in f6bc588
Collaborator
Author
There was a problem hiding this comment.
nschonni
reviewed
Feb 27, 2025
package.json
Outdated
| "eslint": "^9.14.0", | ||
| "expect.js": "^0.3.1", | ||
| "express": "^4.21.1", | ||
| "globals": "^15.12.0", |
Contributor
There was a problem hiding this comment.
markdown-link-check/eslint.config.mjs
Line 2 in f6bc588
nschonni
reviewed
Mar 5, 2025
WillGibson
commented
Mar 6, 2025
| "needle": "^3.3.1", | ||
| "progress": "^2.0.3", | ||
| "proxy-agent": "^6.4.0", | ||
| "xmlbuilder2": "^3.1.1" |
Collaborator
Author
There was a problem hiding this comment.
Only removed one unused dependency in the end ;-)
Collaborator
|
Collaborator
Author
|
@BaseMax Merged in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It occurred to me that we could reduced security risk by removing unused dependencies...
Some of those were false positives because, like Stryker, depcheck does not check markdown-link-check because it has no file extension.