Skip to content
This repository was archived by the owner on May 30, 2020. It is now read-only.
This repository was archived by the owner on May 30, 2020. It is now read-only.

"SyntaxError: missing } after property list" on minified ownCloud core/js/js.js #14

@AdamWill

Description

@AdamWill

I'm working on proposing ownCloud move from mrclay/minify JSMin to JSqueeze (for licensing, maintenance, and performance reasons), but now I actually managed to get an OC 8 install up and asset pipelining enabled and stuck in my test patch to switch, I find JSqueeze seems to produce broken code when minifying ownCloud's core JS.

The file in question is (I think) https://github.com/owncloud/core/blob/01374ab6b54091a8ade4a48f8a67d42c928502e8/core/js/js.js (I'm working with that exact git commit at present). The minified version is https://www.happyassassin.net/temp/ocjs-minified.txt . When I load any ownCloud page with the JSqueeze-minified JS, it fails to work properly at all (lots of layout issues, no menus working etc) and the Firefox debugger shows:

SyntaxError: missing } after property list 5fd4952a40df28b50e6d50759345648a.js:61

ocjs-minified.txt is that line 61 from the big minified file.

I don't see the same issue with the source javascript, or with the same files minified by JSMin or JShrink.

Note, I'm invoking JSqueezeFilter like this:

            $jsqueeze = new JSqueezeFilter();
            $jsqueeze->setSpecialVarRx(false);
            return new FileAsset($root . '/' . $file, array(
                $jsqueeze
            ), $root, $file);

to try and disable the 'special' variable renaming feature, as I saw from other reports it seems to cause issues. If I drop the $jsqueeze->setSpecialVarRx(false); line the error actually goes away (and the JS gets a bit smaller), but the JS still fails to load properly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions