Skip to content
This repository was archived by the owner on May 30, 2020. It is now read-only.
This repository was archived by the owner on May 30, 2020. It is now read-only.

Not PSR-0 compliant #11

@AdamWill

Description

@AdamWill

JSqueeze claims to be PSR-0 (in its composer.json), but it really isn't:

https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-0.md

"A fully-qualified namespace and class must have the following structure \<Vendor Name>\(<Namespace>\)*<Class Name>"

that is, at least one level of namespacing is required, a top-level 'Vendor Name'. JSqueeze is a bare class. I'm now in an argument with my downstream package reviewer because our distribution guidelines don't allow us to put libraries directly in /usr/share/php (to avoid mess and conflicts - nothing else is called JSqueeze yet, but just today I found two things called cssmin, for instance...), but if I put it in a subdirectory, nothing will be able to autoload it without patching.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions