test: fix bolt11 whole btc fixture #475
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| @Test | ||
| // Parses BTC with no unit. Example: 1 BTC → 100,000,000,000 msat. | ||
| void parseWholeBtcNoUnit() { |
There was a problem hiding this comment.
Whole-BTC fixture still encodes zero amount
The new invoice string lnbc1p1some is not a valid 1 BTC amount for parseMsat. Because the parser splits the HRP at the first 1, this string yields an empty amount section (bc) and parseMsat returns -1 (any-amount invoice), so the assertion for 100_000_000_000L will still fail and the test never validates whole-BTC parsing. The fixture needs amount digits before the separator (e.g. lnbc11…) or the parser must revert to lastIndexOf('1').
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_b_68ead00a996c8331a07a0515d4e7f018