Skip to content

Conversation

@tcheeric
Copy link
Owner

@tcheeric tcheeric commented Oct 6, 2025

Summary

Related issue: #____

What changed?

  • Centralized event kind metadata by extending Kind and deprecating Constants.Kind in favor of the enum values.
  • Added a Lombok builder for GenericEvent so callers can assemble events with explicit kind handling.
  • Reworked NIP-52 calendar deserializers to convert through GenericEvent, eliminating manual tag extraction and TODOs.
  • Added unit coverage for the new builder plus calendar event, date-based, time-based, and RSVP decoding flows.

BREAKING

None.

Review focus

  • Ensure the enum-backed kind values still satisfy existing API callers relying on Constants.Kind.
  • Validate the calendar deserializer refactor retains expected tag mapping for NIP-52 events.

Checklist

  • Scope ≤ 300 lines (or split/stack)
  • Title is verb + object (e.g., “Refactor auth middleware to async”)
  • Description links the issue and answers “why now?”
  • BREAKING flagged if needed
  • Tests/docs updated (if relevant)

Testing

  • mvn -q verify (fails: xyz.tcheeric:nostr-java-bom:1.1.1 missing from Maven Central)

Network Access


https://chatgpt.com/codex/tasks/task_b_68e337e2acfc83319e62250f0db94bc8

@codecov-commenter
Copy link

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@tcheeric tcheeric merged commit afdb80a into develop Oct 6, 2025
2 checks passed
@tcheeric tcheeric deleted the codex/create-tasks-for-milestone-1-mt6702 branch October 6, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants