Summary

Related issue: #____

What changed?

• Introduced RelayUri, SubscriptionId, and NipConstants to remove primitive obsession and magic numbers across event validation and replaceable event checks.
• Refactored the WebSocket client stack to build handlers through a WebSocketClientFactory, allowing NostrSpringWebSocketClient and registry helpers to work with typed relay URIs and subscription identifiers.
• Removed deprecated closeSocket shims and the unused tag parent link to reduce dead code and coupling.

BREAKING

None.

Review focus

• Confirm the new factory abstraction wires through the registry/handler lifecycle without altering existing client behaviour.
• Check that the new value objects cover all string-to-identifier call sites involved in subscriptions.

Checklist

• Scope ≤ 300 lines (or split/stack)
• Title is verb + object (e.g., “Refactor auth middleware to async”)
• Description links the issue and answers “why now?”
• BREAKING flagged if needed
• Tests/docs updated (if relevant)

Testing

• mvn -q verify (fails: xyz.tcheeric:nostr-java-bom:1.1.1 missing from Maven Central)

Network Access

• Blocked: https://repo.maven.apache.org/maven2/xyz/tcheeric/nostr-java-bom/1.1.1/

https://chatgpt.com/codex/tasks/task_b_68e337e2acfc83319e62250f0db94bc8