💡 Codex Review

Null-enforced core constructor breaks all default instantiation

The new constructor chain marks sender as @NonNull but both the zero‑argument and note‑service constructors delegate by passing null. Lombok injects a null check for annotated parameters, so new NostrSpringWebSocketClient() (including the singleton holder) and new NostrSpringWebSocketClient(noteService) now throw NullPointerException before initialization, making the client unusable. Either remove the @NonNull requirement for the optional sender or ensure a non‑null identity is supplied when delegating.

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

💡 Codex Review

nostr-java/nostr-java-api/src/main/java/nostr/api/NostrSpringWebSocketClient.java

Lines 39 to 62 in b2abab2

	public NostrSpringWebSocketClient() {
	this(null, new DefaultNoteService());
	}
	/**
	* Construct a client with a single relay configured.
	*/
	public NostrSpringWebSocketClient(String relayName, String relayUri) {
	this();
	setRelays(Map.of(relayName, relayUri));
	}
	/**
	* Construct a client with a custom note service implementation.
	*/
	public NostrSpringWebSocketClient(@NonNull NoteService noteService) {
	this(null, noteService);
	}
	/**
	* Construct a client with a sender identity and a custom note service.
	*/
	public NostrSpringWebSocketClient(@NonNull Identity sender, @NonNull NoteService noteService) {
	this.sender = sender;

Null-enforced core constructor breaks all default instantiation

The new constructor chain marks sender as @NonNull but both the zero‑argument and note‑service constructors delegate by passing null. Lombok injects a null check for annotated parameters, so new NostrSpringWebSocketClient() (including the singleton holder) and new NostrSpringWebSocketClient(noteService) now throw NullPointerException before initialization, making the client unusable. Either remove the @NonNull requirement for the optional sender or ensure a non‑null identity is supplied when delegating.
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

* Open a pull request for review

* Mark a draft as ready

* Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

* @codex fix this CI failure

* @codex address that feedback

@codex address this ci error

Summary

• Removed the duplicate zero-argument constructor and relaxed the sender parameter in the remaining constructors so NostrSpringWebSocketClient can still be instantiated without an explicit identity while retaining Lombok null checks for required collaborators. nostr-java-api/src/main/java/nostr/api/NostrSpringWebSocketClient.javaL39-L75

Testing

• ❌ mvn -q verify (fails because xyz.tcheeric:nostr-java-bom:1.1.1 is unavailable from Maven Central)

View task →