Skip to content

Conversation

@tcheeric
Copy link
Owner

@tcheeric tcheeric commented Oct 6, 2025

Summary

Related issue: #____

What changed?

  • Removed the lingering NetBeans template headers from the public NIP helper and factory classes to cut boilerplate noise.
  • Expanded JavaDoc across the WebSocket client support utilities so their responsibilities and error paths are explicit.
  • Documented BaseTagFactory#create to describe JSON decoding failures surfaced to callers.

BREAKING

None.

Review focus

  • Please confirm the new JavaDoc coverage matches expectations for Milestone 4 and that no behavioral changes slipped in while cleaning the headers.

Checklist

  • Scope ≤ 300 lines (or split/stack)
  • Title is verb + object (e.g., “Refactor auth middleware to async”)
  • Description links the issue and answers “why now?”
  • BREAKING flagged if needed
  • Tests/docs updated (if relevant)

Testing

  • mvn -q verify (fails: xyz.tcheeric:nostr-java-bom:1.1.1 missing from Maven Central)

Network Access


https://chatgpt.com/codex/tasks/task_b_68e337e2acfc83319e62250f0db94bc8

@codecov-commenter
Copy link

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@tcheeric tcheeric merged commit 1c4ddf0 into develop Oct 6, 2025
2 checks passed
@tcheeric tcheeric deleted the codex/create-tasks-for-milestone-1 branch October 6, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants