Skip to content

Conversation

@tcheeric
Copy link
Owner

@tcheeric tcheeric commented Oct 6, 2025

Summary

Related issue: #____

What changed?

  • Refactored WebSocketClientHandler subscription setup/teardown into focused helpers to shrink the method and centralize cleanup.
  • Introduced ZapRequestParameters and routed NIP-57 APIs/builders through it to eliminate seven-argument overloads.
  • Extended the NIP-57 unit suite to cover the new parameter object while documenting test intent.

BREAKING

None.

Review focus

  • Confirm the new subscription handle still closes relay resources and surfaces failures reliably.
  • Ensure ZapRequestParameters preserves existing zap request scenarios.

Checklist

  • Scope ≤ 300 lines (or split/stack)
  • Title is verb + object (e.g., “Refactor auth middleware to async”)
  • Description links the issue and answers “why now?”
  • BREAKING flagged if needed
  • Tests/docs updated (if relevant)

Testing

  • mvn -q verify (fails: xyz.tcheeric:nostr-java-bom:1.1.1 missing from Maven Central)

Network Access


https://chatgpt.com/codex/tasks/task_b_68e337e2acfc83319e62250f0db94bc8

@codecov-commenter
Copy link

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@tcheeric tcheeric merged commit e9a3248 into develop Oct 6, 2025
2 checks passed
@tcheeric tcheeric deleted the codex/create-tasks-for-milestone-1 branch October 6, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants