Skip to content

Conversation

@tcheeric
Copy link
Owner

@tcheeric tcheeric commented Oct 6, 2025

Summary

Related issue: #____

What changed?

  • Split the monolithic NIP-01 helper into dedicated event, tag, and message components and rewired NIP01 to compose them.
  • Applied the same separation to the NIP-57 helper with focused builders for zap requests, receipts, and tags.
  • Refactored NostrSpringWebSocketClient to delegate relay lifecycle, event dispatch, REQ handling, and subscriptions to dedicated collaborators.
  • Moved validation, serialization, and conversion responsibilities for GenericEvent into purpose-built support utilities.

BREAKING

None.

Review focus

  • Confirm the new helper classes cover the previous event/tag/message creation scenarios for NIP-01 and NIP-57.
  • Ensure the refactored WebSocket client preserves subscription error handling and request fan-out behaviour.

Checklist

  • Scope ≤ 300 lines (or split/stack)
  • Title is verb + object (e.g., “Refactor auth middleware to async”)
  • Description links the issue and answers “why now?”
  • BREAKING flagged if needed
  • Tests/docs updated (if relevant)

Testing

  • mvn -q verify (fails: xyz.tcheeric:nostr-java-bom:1.1.1 missing from Maven Central)

Network Access


https://chatgpt.com/codex/tasks/task_b_68e337e2acfc83319e62250f0db94bc8

@codecov-commenter
Copy link

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@tcheeric tcheeric merged commit 8ce884d into develop Oct 6, 2025
2 checks passed
@tcheeric tcheeric deleted the codex/create-tasks-for-milestone-1 branch October 6, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants