You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a shared unchecked exception hierarchy (NostrRuntimeException and specializations) to align with the error-handling policy from Finding 1.3.
Updated existing encoding and crypto exception types to extend the new hierarchy so callers observe consistent runtime behaviour.
Retained NostrException for compatibility while delegating to the protocol-specific base class.
BREAKING
None.
Review focus
Confirm the new base exceptions cover the previously mixed checked/unchecked cases without missing usage sites.
Checklist
Scope ≤ 300 lines (or split/stack)
Title is verb + object (e.g., “Refactor auth middleware to async”)
Description links the issue and answers “why now?”
BREAKING flagged if needed
Tests/docs updated (if relevant)
Testing
mvn -q verify(fails: xyz.tcheeric:nostr-java-bom:1.1.1 missing from Maven Central)
Removing @SneakyThrows caused writeString to declare throws IOException, but the method is still invoked from the relaysTag.getRelays().forEach(...) lambda. Because List.forEach expects a Consumer whose accept method does not allow checked exceptions, this code no longer compiles—IOException cannot be thrown or propagated from the lambda. Wrap the call in a try/catch or avoid declaring a checked exception here so the module builds again.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #____ (code review Finding 1.3)
What changed?
NostrRuntimeExceptionand specializations) to align with the error-handling policy from Finding 1.3.NostrExceptionfor compatibility while delegating to the protocol-specific base class.BREAKING
None.
Review focus
Checklist
Testing
mvn -q verify(fails: xyz.tcheeric:nostr-java-bom:1.1.1 missing from Maven Central)Network Access
https://chatgpt.com/codex/tasks/task_b_68e337e2acfc83319e62250f0db94bc8