Skip to content

Conversation

@tcheeric
Copy link
Owner

@tcheeric tcheeric commented Oct 6, 2025

Summary

Related issue: #____

Responds to code review Finding 1.2 by removing Lombok's @SneakyThrows in favor of explicit exception handling across the event and API layers, so that JSON/URL failures surface as meaningful domain errors.

What changed?

  • Wrapped Jackson parsing in marketplace, merchant, and identity-related events with EventEncodingException so invalid content fails fast without hidden checked exceptions.
  • Updated API builders (NIP-05/25/57/60/61) and BaseTagFactory to convert checked exceptions into descriptive IllegalArgumentException/EventEncodingException instances instead of relying on @SneakyThrows.
  • Revised affected integration/unit tests to document intent, remove @SneakyThrows, and assert JSON parsing success explicitly.

BREAKING

None.

Review focus

  • Confirm the new exception messages and types provide adequate signal for callers consuming the updated APIs.

Checklist

  • Scope ≤ 300 lines (or split/stack)
  • Title is verb + object (e.g., “Refactor auth middleware to async”)
  • Description links the issue and answers “why now?”
  • BREAKING flagged if needed
  • Tests/docs updated (if relevant)

Testing

  • mvn -q verify (fails: xyz.tcheeric:nostr-java-bom:1.1.1 missing from Maven Central)

Network Access

  • Attempted to download https://repo.maven.apache.org/maven2/xyz/tcheeric/nostr-java-bom/1.1.1/nostr-java-bom-1.1.1.pom (artifact not found).

https://chatgpt.com/codex/tasks/task_b_68e337e2acfc83319e62250f0db94bc8

@codecov-commenter
Copy link

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@tcheeric tcheeric merged commit 1a86ffb into develop Oct 6, 2025
2 checks passed
@tcheeric tcheeric deleted the codex/create-tasks-for-milestone-1 branch October 6, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants